Safari alignment of icons buttons and fields broken in stg #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
create-issue-branch
bot
temporarily deployed
to
previews/issues/332-Safari_alignment_of_icons_buttons_and_fields_broken_in_stg
loiswells97
temporarily deployed
to
previews/issues/332-Safari_alignment_of_icons_buttons_and_fields_broken_in_stg
GitHub Actions
Inactive
|
|
…_and_fields_broken_in_stg
loiswells97
temporarily deployed
to
previews/issues/332-Safari_alignment_of_icons_buttons_and_fields_broken_in_stg
GitHub Actions
Inactive
|
loiswells97
temporarily deployed
to
previews/issues/332-Safari_alignment_of_icons_buttons_and_fields_broken_in_stg
GitHub Actions
Inactive
|
patch0
approved these changes
Jan 16, 2023
patch0
deleted the
issues/332-Safari_alignment_of_icons_buttons_and_fields_broken_in_stg
branch
patch0
added a commit
that referenced
this pull request
Jan 17, 2023
## Added - Styling of the projects list (#317) - Ability to collapse and expand the left hand file pane (#316) - Plausible event tracking for left hand file pane (#325) - Last updated field added to the projects table (#319) - Message for empty state on projects (#327) - Rename project action on project index page (#324) - Context menu for project index page actions on mobile (#324) - Danger button styling (#330) ## Changed - Change port number to fix 'no consent token' error (#326) - Long file names truncated rather than scrolling in left hand file pane (#316, #337) - Tab scrollbars only appear when necessary (#331) - Added merge=union gitattribute for this file (#339) ## Fixed - Make sure button text is always centered (#328) - Make theme and font size persist across all pages of the app (#329) - Make dismissing the Beta banner persist across all pages of the app (#329) - Touch area of icon-only buttons (#330, #336) - Delete project action on project index page (#330) - Refactored project list loading to allow loading states to be shown (#330) - Removed unneeded scrollbars on the editor and output panels (#331) - Make Your projects page background extend below the fold (#334)
Merged
patch0
added a commit
that referenced
this pull request
Jan 17, 2023
## Added - Styling of the projects list (#317) - Ability to collapse and expand the left hand file pane (#316) - Plausible event tracking for left hand file pane (#325) - Last updated field added to the projects table (#319) - Message for empty state on projects (#327) - Rename project action on project index page (#324) - Context menu for project index page actions on mobile (#324) - Danger button styling (#330) ## Changed - Change port number to fix 'no consent token' error (#326) - Long file names truncated rather than scrolling in left hand file pane (#316, #337) - Tab scrollbars only appear when necessary (#331) - Added merge=union gitattribute for this file (#339) ## Fixed - Make sure button text is always centered (#328) - Make theme and font size persist across all pages of the app (#329) - Make dismissing the Beta banner persist across all pages of the app (#329) - Touch area of icon-only buttons (#330, #336) - Delete project action on project index page (#330) - Refactored project list loading to allow loading states to be shown (#330) - Removed unneeded scrollbars on the editor and output panels (#331) - Make Your projects page background extend below the fold (#334)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
svgalignment issue in Safari. This was caused by themin-width: min-contentrule onsvgs put in place to preventsvgs shrinking when there is less space. Instead of this, thesvgthat was shrinking was wrapped in an extradiv.Screenshots
Before
After
closes #332