Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the font-size settings #366

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

create-issue-branch[bot]
Copy link
Contributor

@create-issue-branch create-issue-branch bot commented Feb 7, 2023

What's Changed?

  • Hopefully nothing (in the UI at least)!
  • Refactored the font size settings to use React ContextProvider instead of the class on the #app div
  • Removed App tests referring to font size (although these could be rewritten, the advice apparently is not to bother in the case where the ContextProvider is present without a context consumer 馃槄)
  • Added in tests for the ErrorMessage and EditorPanel, including testing font size

closes #360

@create-issue-branch create-issue-branch bot temporarily deployed to previews/issues/360-Refactor_the_font-size_settings February 7, 2023 17:05 Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/360-Refactor_the_font-size_settings February 7, 2023 17:07 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@loiswells97 loiswells97 temporarily deployed to previews/issues/360-Refactor_the_font-size_settings February 7, 2023 17:27 — with GitHub Actions Inactive
@loiswells97 loiswells97 temporarily deployed to previews/issues/360-Refactor_the_font-size_settings February 7, 2023 17:29 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

@loiswells97 loiswells97 marked this pull request as ready for review February 7, 2023 17:34
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

@loiswells97 loiswells97 merged commit 57994ae into main Feb 9, 2023
@loiswells97 loiswells97 deleted the issues/360-Refactor_the_font-size_settings branch February 9, 2023 11:24
@patch0 patch0 mentioned this pull request Mar 2, 2023
patch0 added a commit that referenced this pull request Mar 2, 2023
### Added

- Added release notes to `README.md` (#354)
- Pagination on 'Your projects' page (#338)

### Changed

- Switched `processing` implementation from `p5.py` to `py5.py` (#364)
- Font size only scales code, text output and error messages rather than
the whole UI (#365)
- Refactored font size settings to use React `ContextProvider` (#366)
- Clicking 'login to save' triggers save/remix after successful login
(#368)
- Renaming project, adding new file or renaming file triggers autosave
immediately (#368)
- Bump http-cache-semantics from 4.1.0 to 4.1.1 (#361)
- Removed redundant file indices (#377)
- Use GraphQL API to fetch project index page (#376)

### Fixed

- Make sure accessDeniedData login button redirects to /projects (#356)
- Allowed HTML projects to load (#362)
- Scrollbar flash on first load (#358)
- Scrollbar appearing in visual output (#358)
- Sense hat visual output height (#358)
- Web component font size (#358)
- Web component icon visibility (#358)
- Renaming project, adding new file or renaming file always triggers
autosave (#368)
- Use `HtmlRunner` for `html` projects (#378)
- Accessibility Fixes (#373, #382, #383)
- Hide the codemirror `cm-widgetBuffer` (#384, #395)
- Height discrepancy of the tab containers (#385)

---------

Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the font-size settings
2 participants