Refactor the font-size settings #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
create-issue-branch
bot
temporarily deployed
to
previews/issues/360-Refactor_the_font-size_settings
loiswells97
temporarily deployed
to
previews/issues/360-Refactor_the_font-size_settings
GitHub Actions
Inactive
|
|
|
loiswells97
temporarily deployed
to
previews/issues/360-Refactor_the_font-size_settings
GitHub Actions
Inactive
loiswells97
temporarily deployed
to
previews/issues/360-Refactor_the_font-size_settings
GitHub Actions
Inactive
|
|
|
chrisruk
approved these changes
Feb 9, 2023
Merged
patch0
added a commit
that referenced
this pull request
Mar 2, 2023
### Added - Added release notes to `README.md` (#354) - Pagination on 'Your projects' page (#338) ### Changed - Switched `processing` implementation from `p5.py` to `py5.py` (#364) - Font size only scales code, text output and error messages rather than the whole UI (#365) - Refactored font size settings to use React `ContextProvider` (#366) - Clicking 'login to save' triggers save/remix after successful login (#368) - Renaming project, adding new file or renaming file triggers autosave immediately (#368) - Bump http-cache-semantics from 4.1.0 to 4.1.1 (#361) - Removed redundant file indices (#377) - Use GraphQL API to fetch project index page (#376) ### Fixed - Make sure accessDeniedData login button redirects to /projects (#356) - Allowed HTML projects to load (#362) - Scrollbar flash on first load (#358) - Scrollbar appearing in visual output (#358) - Sense hat visual output height (#358) - Web component font size (#358) - Web component icon visibility (#358) - Renaming project, adding new file or renaming file always triggers autosave (#368) - Use `HtmlRunner` for `html` projects (#378) - Accessibility Fixes (#373, #382, #383) - Hide the codemirror `cm-widgetBuffer` (#384, #395) - Height discrepancy of the tab containers (#385) --------- Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed?
ContextProviderinstead of the class on the#appdivApptests referring to font size (although these could be rewritten, the advice apparently is not to bother in the case where theContextProvideris present without a context consumer 馃槄)ErrorMessageandEditorPanel, including testing font sizecloses #360