Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility of saving reminder banner #382

Merged

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #380

@create-issue-branch create-issue-branch bot temporarily deployed to previews/a11y/380-Fix_accessibility_of_saving_reminder_banner February 24, 2023 10:51 Inactive
@github-actions
Copy link

@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/a11y/380-Fix_accessibility_of_saving_reminder_banner February 24, 2023 12:18 — with GitHub Actions Inactive
@loiswells97 loiswells97 marked this pull request as ready for review February 24, 2023 12:19
@github-actions
Copy link

@loiswells97 loiswells97 temporarily deployed to previews/a11y/380-Fix_accessibility_of_saving_reminder_banner February 24, 2023 12:21 — with GitHub Actions Inactive
@github-actions
Copy link

@github-actions
Copy link

Copy link
Contributor

@IzzySmillie IzzySmillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@loiswells97 loiswells97 merged commit dc33827 into main Feb 27, 2023
@loiswells97 loiswells97 deleted the a11y/380-Fix_accessibility_of_saving_reminder_banner branch February 27, 2023 15:17
@patch0 patch0 mentioned this pull request Mar 2, 2023
patch0 added a commit that referenced this pull request Mar 2, 2023
### Added

- Added release notes to `README.md` (#354)
- Pagination on 'Your projects' page (#338)

### Changed

- Switched `processing` implementation from `p5.py` to `py5.py` (#364)
- Font size only scales code, text output and error messages rather than
the whole UI (#365)
- Refactored font size settings to use React `ContextProvider` (#366)
- Clicking 'login to save' triggers save/remix after successful login
(#368)
- Renaming project, adding new file or renaming file triggers autosave
immediately (#368)
- Bump http-cache-semantics from 4.1.0 to 4.1.1 (#361)
- Removed redundant file indices (#377)
- Use GraphQL API to fetch project index page (#376)

### Fixed

- Make sure accessDeniedData login button redirects to /projects (#356)
- Allowed HTML projects to load (#362)
- Scrollbar flash on first load (#358)
- Scrollbar appearing in visual output (#358)
- Sense hat visual output height (#358)
- Web component font size (#358)
- Web component icon visibility (#358)
- Renaming project, adding new file or renaming file always triggers
autosave (#368)
- Use `HtmlRunner` for `html` projects (#378)
- Accessibility Fixes (#373, #382, #383)
- Hide the codemirror `cm-widgetBuffer` (#384, #395)
- Height discrepancy of the tab containers (#385)

---------

Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix accessibility of saving reminder banner
2 participants