-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing HTML projects to render #362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 12:06
— with
GitHub Actions
Inactive
|
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 12:15
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 13:02
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 13:09
— with
GitHub Actions
Inactive
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 13:10
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 13:12
— with
GitHub Actions
Inactive
|
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 14:27
— with
GitHub Actions
Inactive
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 14:40
— with
GitHub Actions
Inactive
|
IzzySmillie
temporarily deployed
to
previews/allow-html-projects
February 3, 2023 14:52
— with
GitHub Actions
Inactive
|
loiswells97
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 Looks like it's still connected up to the PythonRunner but I guess that's a problem for another day!
Merged
patch0
added a commit
that referenced
this pull request
Mar 2, 2023
### Added - Added release notes to `README.md` (#354) - Pagination on 'Your projects' page (#338) ### Changed - Switched `processing` implementation from `p5.py` to `py5.py` (#364) - Font size only scales code, text output and error messages rather than the whole UI (#365) - Refactored font size settings to use React `ContextProvider` (#366) - Clicking 'login to save' triggers save/remix after successful login (#368) - Renaming project, adding new file or renaming file triggers autosave immediately (#368) - Bump http-cache-semantics from 4.1.0 to 4.1.1 (#361) - Removed redundant file indices (#377) - Use GraphQL API to fetch project index page (#376) ### Fixed - Make sure accessDeniedData login button redirects to /projects (#356) - Allowed HTML projects to load (#362) - Scrollbar flash on first load (#358) - Scrollbar appearing in visual output (#358) - Sense hat visual output height (#358) - Web component font size (#358) - Web component icon visibility (#358) - Renaming project, adding new file or renaming file always triggers autosave (#368) - Use `HtmlRunner` for `html` projects (#378) - Accessibility Fixes (#373, #382, #383) - Hide the codemirror `cm-widgetBuffer` (#384, #395) - Height discrepancy of the tab containers (#385) --------- Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://github.com/RaspberryPiFoundation/digital-editor/issues/64
If checking locally, checkout
html-starter-project
in theeditor-api
and run thecreate_starter
rake task -> then go to/projects/blank-html-starter
index.html
for html projects andmain.py
as default