Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing HTML projects to render #362

Merged
merged 11 commits into from
Feb 3, 2023
Merged

Allowing HTML projects to render #362

merged 11 commits into from
Feb 3, 2023

Conversation

IzzySmillie
Copy link
Contributor

@IzzySmillie IzzySmillie commented Feb 3, 2023

Part of: https://github.com/RaspberryPiFoundation/digital-editor/issues/64
If checking locally, checkout html-starter-project in the editor-api and run the create_starter rake task -> then go to /projects/blank-html-starter


  • Adds project type check and pushes index.html for html projects and main.py as default
  • Adds tests for the requesting of a project for both project types

Screenshot 2023-02-03 at 14 52 28

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 12:06 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 12:15 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 13:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 13:09 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 13:10 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 13:12 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie self-assigned this Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 14:27 — with GitHub Actions Inactive
@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 14:40 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie temporarily deployed to previews/allow-html-projects February 3, 2023 14:52 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

@IzzySmillie IzzySmillie marked this pull request as ready for review February 3, 2023 14:57
@IzzySmillie IzzySmillie changed the title Allowing HTML projects Allowing HTML projects to render Feb 3, 2023
Copy link
Contributor

@loiswells97 loiswells97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 Looks like it's still connected up to the PythonRunner but I guess that's a problem for another day!

@IzzySmillie IzzySmillie merged commit e840d81 into main Feb 3, 2023
@IzzySmillie IzzySmillie deleted the allow-html-projects branch February 3, 2023 16:16
@patch0 patch0 mentioned this pull request Mar 2, 2023
patch0 added a commit that referenced this pull request Mar 2, 2023
### Added

- Added release notes to `README.md` (#354)
- Pagination on 'Your projects' page (#338)

### Changed

- Switched `processing` implementation from `p5.py` to `py5.py` (#364)
- Font size only scales code, text output and error messages rather than
the whole UI (#365)
- Refactored font size settings to use React `ContextProvider` (#366)
- Clicking 'login to save' triggers save/remix after successful login
(#368)
- Renaming project, adding new file or renaming file triggers autosave
immediately (#368)
- Bump http-cache-semantics from 4.1.0 to 4.1.1 (#361)
- Removed redundant file indices (#377)
- Use GraphQL API to fetch project index page (#376)

### Fixed

- Make sure accessDeniedData login button redirects to /projects (#356)
- Allowed HTML projects to load (#362)
- Scrollbar flash on first load (#358)
- Scrollbar appearing in visual output (#358)
- Sense hat visual output height (#358)
- Web component font size (#358)
- Web component icon visibility (#358)
- Renaming project, adding new file or renaming file always triggers
autosave (#368)
- Use `HtmlRunner` for `html` projects (#378)
- Accessibility Fixes (#373, #382, #383)
- Hide the codemirror `cm-widgetBuffer` (#384, #395)
- Height discrepancy of the tab containers (#385)

---------

Co-authored-by: Lois Wells <lois.wells@raspberrypi.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants