Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower packages must be unversioned #38

Closed
2 tasks
unscriptable opened this issue Jun 11, 2014 · 2 comments
Closed
2 tasks

Bower packages must be unversioned #38

unscriptable opened this issue Jun 11, 2014 · 2 comments

Comments

@unscriptable
Copy link
Contributor

bower is making the version property optional in bower.json. While this is inconsistent with npm / package.json, it's not a road block since we can simply stop versioning bower packages. If bower someday decides to allow multiple versions of a package, we can revisit the solution. For now, this should work fine.

We will need to apply a fix in [at least] two places:

  1. where rave crawls for bower packages
  2. where rave normalizes module names
@unscriptable unscriptable changed the title bower packages must be unversioned Bower packages must be unversioned Jun 11, 2014
@KidkArolis
Copy link
Contributor

What about defaulting the version to "0.0.0" in the crawler, that way there is no need to change the normalization?

@unscriptable
Copy link
Contributor Author

I noticed that you defaulted to "0.0.0" in one of the PRs. I like that this keeps the logic the same. 👍

I was briefly worried about situations wherein a package is a dependency in both npm and bower (e.g. this could happen with a popular package like when.js), but I think this still works out. Closing in favor of your suggestion. Add it to #40?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants