-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Atomic swap execution #1083
Conversation
…ed UI actions to switch to atomic swaps page.
…ently. Removed almost all of create asset dialog contents.
Broke swap details out into a struct.
Added swap signing logic, somewhat tested. Moved wallet.h functions from private to public for usage from another class. Related child functions were already public, so the more general parent functions should have been public before.
Needs UX on complete/error, but they function completely. Trades are untested so far, and likely full of bugs :) Also a hard-coded fee offset which I don't love.
Added clear functionality.
Fixed display of buy/sell order pricing in confirmation dialog. Fixed error message display.
Looks technically good to me. I see no alternative to make SelectCoins and SelectAssets public in wallet.h, as we definitely do not want to merge all the swap functionality into the wallet code. |
The internal working functions inside of SelectCoins and SelectAssets are already public as-is, so its not too strange to make the primary SelectCoins/SelectAssets public themselves. |
-This is a very interesting technology and a nice bit of coding work. -I am closing this PR at this time. It can be re-opened later if community consensus justifies doing so. |
Adds basic execution of atomic swaps directly into wallet.
Buy/Sell orders have been the most heavily tested so far.