Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Atomic swap execution #1083

Closed
wants to merge 13 commits into from
Closed

[Feature] Atomic swap execution #1083

wants to merge 13 commits into from

Commits on Jun 13, 2021

  1. Added support for displaying atomic swap transactions properly in wal… 

    …let.
    @ben-abraham
    ben-abraham committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    d152caa View commit details
    Browse the repository at this point in the history

  2. Added back section removed during testing.

    @ben-abraham
    ben-abraham committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    b573102 View commit details
    Browse the repository at this point in the history

  3. Added tr() calls, Fixed whitespace, Fixed compiler warnings

    @ben-abraham
    ben-abraham committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    3f4c567 View commit details
    Browse the repository at this point in the history

  4. ws

    @ben-abraham
    ben-abraham committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    e67f1ed View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Created boilplate atomicswap page copied from create assets. Also add… 

    …ed UI actions to switch to atomic swaps page.
    @ben-abraham
    ben-abraham committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    e24cfe8 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Added simple signed partial parsing and validation, no execution curr… 

    …ently.

Removed almost all of create asset dialog contents.
    @ben-abraham
    ben-abraham committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    2ad0bdc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Finished parsing logic and UI display. 

    Broke swap details out into a struct.
    @ben-abraham
    ben-abraham committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    597a003 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2021

  1. Added swap completion logic, mostly tested. 

    Added swap signing logic, somewhat tested.
Moved wallet.h functions from private to public for usage from another class. Related child functions were already public, so the more general parent functions should have been public before.
    @ben-abraham
    ben-abraham committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    47a0a87 View commit details
    Browse the repository at this point in the history

  2. Swaps are working! 

    Needs UX on complete/error, but they function completely. Trades are untested so far, and likely full of bugs :)
Also a hard-coded fee offset which I don't love.
    @ben-abraham
    ben-abraham committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    8a5dff7 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Added message box on success/fail of swap. 

    Added clear functionality.
    @ben-abraham
    ben-abraham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    caaa207 View commit details
    Browse the repository at this point in the history

  2. Added proper main screen icons for atomic swap.

    @ben-abraham
    ben-abraham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    cfaa655 View commit details
    Browse the repository at this point in the history

  3. Fixed execution of buy orders. 

    Fixed display of buy/sell order pricing in confirmation dialog.
Fixed error message display.
    @ben-abraham
    ben-abraham committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    8bccbc3 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2021

  1. Remove SINGLE|ANYONECANPAY from translation string.

    @ben-abraham
    ben-abraham committed Jun 27, 2021
    Configuration menu
    Copy the full SHA
    993f991 View commit details
    Browse the repository at this point in the history