You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Need to refactor the (now common) vec3 class, some in preparation for issues above. For example, this will address some of the color functionality that we'd like to add (by inheritance or something else).
Separate declaration from definition — create new src/common/vec3.cpp which contains definitions of many of the vec3 methods. Simple function definitions should be defined in-class (implicitly/possibly inlined).
Eliminate explicit inline keyword
Cull unused methods
Other miscellaneous
The text was updated successfully, but these errors were encountered:
Related issues:
inline
keyword unnecessary #153<<
and>>
operators overloaded but never used #156Need to refactor the (now common)
vec3
class, some in preparation for issues above. For example, this will address some of the color functionality that we'd like to add (by inheritance or something else).Separate declaration from definition — create new
src/common/vec3.cpp
which contains definitions of many of thevec3
methods. Simple function definitions should be defined in-class (implicitly/possibly inlined).Eliminate explicit
inline
keywordCull unused methods
Other miscellaneous
The text was updated successfully, but these errors were encountered: