Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vec3 class #215

Closed
hollasch opened this issue Oct 18, 2019 · 2 comments
Closed

Refactor vec3 class #215

hollasch opened this issue Oct 18, 2019 · 2 comments
Assignees
Milestone

Comments

@hollasch
Copy link
Collaborator

Related issues:

Need to refactor the (now common) vec3 class, some in preparation for issues above. For example, this will address some of the color functionality that we'd like to add (by inheritance or something else).

  • Separate declaration from definition — create new src/common/vec3.cpp which contains definitions of many of the vec3 methods. Simple function definitions should be defined in-class (implicitly/possibly inlined).

  • Eliminate explicit inline keyword

  • Cull unused methods

  • Other miscellaneous

@hollasch hollasch self-assigned this Oct 18, 2019
@hollasch hollasch added this to the v3 milestone Oct 18, 2019
@hollasch
Copy link
Collaborator Author

See comments in #153 regarding performance when separating declaration from definition for vec3 class methods.

hollasch added a commit that referenced this issue Oct 21, 2019
Resolves #153
Resolves #156
Resolves #215
@hollasch hollasch mentioned this issue Oct 21, 2019
hollasch added a commit that referenced this issue Oct 21, 2019
Resolves #153
Resolves #156
Resolves #215
@hollasch
Copy link
Collaborator Author

hollasch commented Oct 21, 2019

Resolved in #226, changes in development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant