-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lighting Oversaturation Problem #93
Comments
fixed it, here is my change: in main.cc, change the last line from |
Closed
See pull request RayTracing/TheRestOfYourLife#5 This isn't the solution, but contains valuable information. I have a solution sketched out in the original book repo, and will resurface it here after the v2 release to web. |
Closed
hollasch
added a commit
that referenced
this issue
Oct 21, 2019
There are still many places in the code where we're using `vec3` for color data, but this change fixes the lighting oversaturation problem, and also replaces colors with NaN components with a signalling color (pure cyan). Resolves #93
Merged
hollasch
added a commit
that referenced
this issue
Oct 21, 2019
There are still many places in the code where we're using `vec3` for color data, but this change fixes the lighting oversaturation problem, and also replaces colors with NaN components with a signalling color (pure cyan). Resolves #93
Resolved in #226, changes in development branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After working on the Cornell box, I noticed some trouble with the lighting, especially when I had a large light, which in the book said would help with the noise. I replaced one of the boxes with a glass sphere and noticed the obvious problem with the light of my image. Even with 1000 secondary rays, it didn't fix it.
I eventually figured out that there needed to be a value cap on the colors, so it wouldn't oversaturate. This might have been covered in the next book "Ray Tracing the Rest of Your Life", but with the final image of this book having a glass sphere and a very bright light, I figured it might be useful to mention it.
Here's my final image with that color cap:
The text was updated successfully, but these errors were encountered: