Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN change request #328

Closed
eddelbuettel opened this issue Apr 16, 2021 · 4 comments
Closed

CRAN change request #328

eddelbuettel opened this issue Apr 16, 2021 · 4 comments

Comments

@eddelbuettel
Copy link
Member

In email this morning to us and possibly over a hundred others (!!):

These have Markdown vignettes without at least suggesting one of
markdown or rmarkdown, which currently "works" because markdown is a
strong dependency of knitr. However, the knitr maintainer wants to
change this so that knitr only suggests markdown in the future.

With the current CRAN version of knitr, building your package vignettes
now fails with something like

The 'markdown' package should be declared as a dependency of the
'unrepx' package (e.g., in the 'Suggests' field of DESCRIPTION),
because the latter contains vignette(s) built with the 'markdown'
package. Please see yihui/knitr#1864 for
more information.

(for vignette engine knitr::knitr et al) or

The 'rmarkdown' package should be declared as a dependency of the
'validate' package (e.g., in the 'Suggests' field of DESCRIPTION),
because the latter contains vignette(s) built with the 'rmarkdown'
package. Please see yihui/knitr#1864 for
more information.

(for vignette engine knitr::rmarkdown).

See

yihui/knitr#1864

for more information.

Can you please add the missing dependencies and submit a new version of
your package to CRAN as quickly as possible?

Please fix before 2021-05-14 to safely retain your package on CRAN.

I think this only means adding rmarkdown to Suggests:. I will take care of it.

@eddelbuettel
Copy link
Member Author

That appears to be the case. I just made the same change (with some other minor modernization that came up) in my RcppAPT package that was also affected.

@eddelbuettel
Copy link
Member Author

And for completeness RcppAPT sailed through with the change and got pretest-publish (which we can't as this triggers the 'two-stage build turned off' note:

image

@eddelbuettel
Copy link
Member Author

This was taken care of in d64319a

@eddelbuettel
Copy link
Member Author

Or as I just learned not quite :) The knitr package now enforces rmarkdown whether you use an rmarkdown vignette style or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant