Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quick ref vignette #932

Closed
dongzhuoer opened this issue Dec 22, 2018 · 3 comments · Fixed by #933
Closed

update quick ref vignette #932

dongzhuoer opened this issue Dec 22, 2018 · 3 comments · Fixed by #933

Comments

@dongzhuoer
Copy link
Contributor

dongzhuoer commented Dec 22, 2018

  1. Named[] should be Named() in last statement of "Create simple vectors" card, see Named[] should be Named() in quick ref vignette #929
  2. glob.ls() need a bool argument in "Retrieve information from environment" section of "Environment" card, see glob.ls() need a bool argument #930
  3. add definition for glob in Environment" card, see add definition for glob #931
@eddelbuettel
Copy link
Member

Nice catch re glob. I think this would make sense:

R> cppFunction("CharacterVector foo() { Environment glob=Environment::global_env(); return glob.ls(true); }" )
R> foo()
[1] ".Random.seed" "foo"
R> 

So how about you prepare a new (single) PR with the three suggested changes as well as a ChangeLog entry with your name and email?

@eddelbuettel
Copy link
Member

@dongzhuoer Are you going to prepare a new PR now that we settled on these three changes in one submission? Else I can make the change directly too. Let us know.

@dongzhuoer
Copy link
Contributor Author

Sorry, I'm a graduate student. I was busy doing homework a few days ago.

I issue #933, we can discuss there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants