Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quick ref vignette #932

Closed
dongzhuoer opened this Issue Dec 22, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@dongzhuoer
Copy link
Contributor

dongzhuoer commented Dec 22, 2018

  1. Named[] should be Named() in last statement of "Create simple vectors" card, see #929
  2. glob.ls() need a bool argument in "Retrieve information from environment" section of "Environment" card, see #930
  3. add definition for glob in Environment" card, see #931
@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Dec 23, 2018

Nice catch re glob. I think this would make sense:

R> cppFunction("CharacterVector foo() { Environment glob=Environment::global_env(); return glob.ls(true); }" )
R> foo()
[1] ".Random.seed" "foo"
R> 

So how about you prepare a new (single) PR with the three suggested changes as well as a ChangeLog entry with your name and email?

@eddelbuettel

This comment has been minimized.

Copy link
Member

eddelbuettel commented Dec 25, 2018

@dongzhuoer Are you going to prepare a new PR now that we settled on these three changes in one submission? Else I can make the change directly too. Let us know.

@dongzhuoer

This comment has been minimized.

Copy link
Contributor Author

dongzhuoer commented Dec 26, 2018

Sorry, I'm a graduate student. I was busy doing homework a few days ago.

I issue #933, we can discuss there.

eddelbuettel added a commit that referenced this issue Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.