-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codecov uploads not working #941
Comments
Indeed, I had left that open. Will look into this -- thanks for the detailed suggestion. |
re-enable codecov.io coverage with thanks to Ralf (closes #941)
@rstub Looks like it broke again. I'm at a loss as to why. Any idea? |
At first glance it looks like coverage dropped when you changed the version to 1.0.1: https://codecov.io/gh/RcppCore/Rcpp/commit/7ad7dc11c8cbd088737098a50ba4ecfab7be798a I remember that some tests don’t run on CRAN, ie not for releases. Is there a way to force execution of the tests even for three digit release numbers? |
Hm, but that test for 'is it a three digit release' has been there forever and has not changed Lines 46 to 53 in 0837b35
Plus we have the environment variable to override Line 25 in 0837b35
|
But on reflection, I think you are spot on. "1.0.1" is a release version that turns tests off at CRAN, it does so here (by accident) so the setting in the Dockerfile simply does not work. I may need another check for a Travis environment variable in |
Maybe |
Yes I now suspect that But again, well spotted. I was so focussed on 'why does coverage not run' that I did not realize that the related 'hm jobs only take 8 mins instead of around 15 mins' was the driver. Should be better now as I altered the test driver in |
Now committed. When I wrote the comment above I had it written here but not yet pushed so you couldn't have seen that :) |
On https://codecov.io/github/RcppCore/Rcpp?branch=master one sees no test coverage reports uploaded in the last 6 months. I guess this happened when Travis CI was changed to use docker containers. I recently had the same problem and solved it like this:
CODECOV_TOKEN
with that value.-e CODECOV_TOKEN
to the docker arguments when callingcovr::codecov()
.The text was updated successfully, but these errors were encountered: