-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting parenthesis characters as default value to function parameters yields a compiling error #975
Comments
I think this is a bug in the hand-rolled C++ parser used for attributes. Since this is somewhat of an edge case, it's unlikely we'll fix this quickly -- but pull requests are welcome! |
Seconded. I glanced iinto |
There's no regex, it's just a lookahead tokenizer. We have some logic to
exclude e.g. commas within quotes but I don't know if this can be easily
extended to parentheses. Would indeed be happy to review a PR.
…On Tue, Jul 9, 2019 at 5:01 PM Dirk Eddelbuettel ***@***.***> wrote:
Seconded. I glanced iinto src/attributes.cpp but didn't find the regexp
immediately. Sounds entirely fixable with a bit of patience so
contributions welcome...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#975?email_source=notifications&email_token=AAAZPR2UVB4OOZJB55IIQXLP6T4DFA5CNFSM4H7C3XYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRQSOQ#issuecomment-509806906>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAZPRZWPRSJU6VKAGGHDW3P6T4DFANCNFSM4H7C3XYA>
.
|
I've made the corrections and am going to make a pull request. |
Thanks for the PR and the tests! |
Defining the following function:
gives:
Inverting the default values, leads to the same error:
Replacing one of the default values with another value, remove the error:
The text was updated successfully, but these errors were encountered: