Feature/win debug dll (closes #1035) #1037
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1037 +/- ##
==========================================
+ Coverage 91.92% 91.92% +<.01%
==========================================
Files 64 64
Lines 2935 2936 +1
==========================================
+ Hits 2698 2699 +1
Misses 237 237
Continue to review full report at Codecov.
|
| } else { | ||
| if (verbose && windowsDebugDLL) { | ||
| message("The 'windowsDebugDLL' toggle is ignored on non-Windows platforms.") | ||
| windowsDebugDLL <- FALSE # now we do not need to deal with OS choice below |
There was a problem hiding this comment.
Shouldn't this be outside the if()? As it stands now, this will only trigger if verbose = TRUE is passed (it normally isn't.)
There was a problem hiding this comment.
Nice catch. I think you are correct. Will fix.
There was a problem hiding this comment.
New variant:
if (verbose) {
message("The 'windowsDebugDLL' toggle is ignored on "
"non-Windows platforms.")
}
windowsDebugDLL <- FALSE # now we do not need to deal with OS choice below
} # #nocov end Better...
| @@ -9,6 +9,8 @@ | |||
| \itemize{ | |||
| \item Safer \code{Rcpp_list*}, \code{Rcpp_lang*} and | |||
| \code{Function.operator()} (Romain in \ghpr{1014}, \ghit{1015}). | |||
| \item A number of \code{#nocov} markers were added (Dirk in | |||
| \ghprP1036}). | |||
There was a problem hiding this comment.
| \ghprP1036}). | |
| \ghpr{1036}). |
There was a problem hiding this comment.
Hmpf. I could swear I can a check which should spotted that. Will fix!
| @@ -67,7 +67,7 @@ sourceCpp <- function(file = "", | |||
| } else { | |||
| if (windowsDebugDLL) { | |||
| if (verbose) { | |||
| message("The 'windowsDebugDLL' toggle is ignored on " | |||
| message("The 'windowsDebugDLL' toggle is ignored on ", | |||
There was a problem hiding this comment.
Well it was a last-second edit to comply with the @jjallaire style of less than 80 columns. I find 100 or so easier and this is what I got for it :)
|
Thanks for the review. There isn't all that much else here, and you caught the one obvious thinko, so I think I'll merge this now. |
| \item Unavailable packages referred to in \code{LinkingTo} are now | ||
| reported (Dirk in \ghpr{1027} fixing \ghit{1026}). | ||
| \item The \code{sourceCpp} function can now create a debug DLL on | ||
| Windows (Dirk in \ghpr{1037} fixing \ghit{ghit}). |
There was a problem hiding this comment.
Also, there's \ghit{ghit}
There was a problem hiding this comment.
Bah. Something must be wrong with the water. Or the coffee. Or both.
Changed to \ghit{1035}. Thanks again.
See the discussion and resolution in #1035 -- this addresses a narrow need for debugging when using windows and
sourceCpp().Checklist
R CMD checkstill passes all tests