Skip to content

Two more shields #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2020
Merged

Two more shields #1059

merged 2 commits into from
Mar 24, 2020

Conversation

eddelbuettel
Copy link
Member

Adds two more Shield<SEXP> around Rf_lang2 results.

Thanks to @romainfrancois and @lionel- for spotting the need for it when the first of these was posted to r-devel.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

kevinushey
kevinushey approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kevinushey
kevinushey reviewed Mar 24, 2020
View reviewed changes
@eddelbuettel eddelbuettel merged commit 391d48e into master Mar 24, 2020
@eddelbuettel eddelbuettel deleted the bugfix/more_shields branch March 24, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinushey kevinushey kevinushey approved these changes

+1 more reviewer

@romainfrancois romainfrancois romainfrancois left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddelbuettel @kevinushey @romainfrancois