Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip remainder of one test file if on Solaris #1065

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

eddelbuettel
Copy link
Member

Skip exceptions tests after line 55 just like Windows does

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was writing exactly this code in a separate local branch as well :-)

@codecov-io
Copy link

Codecov Report

Merging #1065 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1065   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          64       64           
  Lines        2782     2782           
=======================================
  Hits         2660     2660           
  Misses        122      122           

@eddelbuettel eddelbuettel merged commit c9cf6aa into master Apr 10, 2020
@eddelbuettel eddelbuettel deleted the bugfix/skip_some_tests_on_sunos branch April 10, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants