Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete and confusing comment #1109

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Remove obsolete and confusing comment #1109

merged 1 commit into from
Aug 20, 2020

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Aug 20, 2020

The comment was added in commit cfdb196 to explain why Rcpp_list6() is special.
However, in a later commit 6eac444 Rcpp_list{2,3,4,5}() were added with similar definitions.
This means that Rcpp_list6() is no longer special, and the comment is now confusing rather than informative.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Prefereably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@ellert
Remove obsolete and confusing comment
0ce01c8 
The comment was added in commit cfdb196
to explain why Rcpp_list6() is special.
However, in a later commit 6eac444
Rcpp_list{2,3,4,5}() were added with similar definitions.
This means that Rcpp_list6() is no longer special, and the comment is now
confusing rather than informative.
eddelbuettel
eddelbuettel approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, besides being wrong as a comment it also required painful follow-up PRs to clean the release it became part of.

@eddelbuettel eddelbuettel merged commit c5a97a3 into RcppCore:master Aug 20, 2020
@ellert ellert deleted the remove-confusing-comment branch August 20, 2020 12:42
@eddelbuettel
Copy link
Member

Thanks again for your PR and patience. This is now 'live' in Rcpp 1.0.6 which just got to CRAN under our bi-annual release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellert @eddelbuettel