New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set finalizer on internal function (closes #1114) #1115

Merged

eddelbuettel merged 2 commits into master from feature/finalize_internal_functions

Oct 27, 2020

Member

eddelbuettel commented Oct 27, 2020

This addresses #1114 by switching the setfinalizer argument to TRUE

A full reverse-depends check as been run as is summarized in this commit.

Checklist

Code compiles correctly
R CMD check still passes all tests
Prefereably, new tests were added which fail without the change
Document the changes by file in ChangeLog

eddelbuettel added 2 commits

October 25, 2020 17:29


          switch XPtr finalizer argument from false to true

868aa1f


          roll minor version

d6bddf2

eddelbuettel merged commit a788856 into master

eddelbuettel deleted the feature/finalize_internal_functions branch

October 27, 2020 02:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment