Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add small unit test for coerce #1237

Merged
merged 1 commit into from
Oct 27, 2022
Merged

add small unit test for coerce #1237

merged 1 commit into from
Oct 27, 2022

Conversation

kevinushey
Copy link
Contributor

Pull Request Template for Rcpp

Related to #1236; this PR adds a unit test for the Rbyte -> const char* coercion routine used in Rcpp.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

@eddelbuettel
Copy link
Member

eddelbuettel commented Oct 27, 2022 •
edited
Loading

Can you put the commit onto my pending branch?

Or else I can rebase I suppose.

eddelbuettel
eddelbuettel approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Will merge to have available for the other PR.

@eddelbuettel eddelbuettel merged commit 198ecb3 into master Oct 27, 2022
@eddelbuettel eddelbuettel deleted the feature/coerce-unit-tests branch October 27, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinushey @eddelbuettel