Safer DataFrame(SEXP) ctor
#301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you. No timeline for next release but we've been at a two month rhythm of late so possibly July once all the conferencing is over. |
eddelbuettel
added a commit
that referenced
this pull request
May 27, 2015
Safer `DataFrame(SEXP)` ctor
|
Sure. No trouble, i have a workaround in place for dplyr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivations are clearly explained in tidyverse/dplyr#998 reported by @spkal
There was a risk of garbage collection triggered by the default constructor of
Vector, called implicitly by theDataFrame(SEXP)constructor before theSEXPgets a chance of being protected.This trivial change should fix it.