Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding contributing.md #414

Merged
merged 2 commits into from
Jan 10, 2016
Merged

Conversation

eddelbuettel
Copy link
Member

No description provided.

@kevinushey
Copy link
Contributor

Looks great! Thanks for the minor tweaks.

@eddelbuettel
Copy link
Member Author

So ... shall we fold it in? And thanks for your excellent start. I really only rounded out some corners and clarified a wee bit at the end.

@kevinushey
Copy link
Contributor

Let's perhaps wait for one last look from @jjallaire and @thirdwing and then fold it in.

@eddelbuettel
Copy link
Member Author

👍

1 similar comment
@thirdwing
Copy link
Member

👍

@eddelbuettel
Copy link
Member Author

Thank you both. I will fold it now. Release 0.12.3 still on track and grinding through rev.dep. checks.

eddelbuettel added a commit that referenced this pull request Jan 10, 2016
@eddelbuettel eddelbuettel merged commit 6620a02 into master Jan 10, 2016
@eddelbuettel eddelbuettel deleted the feature/adding-contributing.md branch January 10, 2016 00:42
This was referenced Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants