Sugar cbind with unit tests #447
Conversation
|
Looks pretty good to me. |
|
|
||
| } // cbind_impl | ||
|
|
||
| #define MakeBindable(x) (cbind_impl::detail::MakeBindable(x)(x)) |
There was a problem hiding this comment.
Should this macro get undefined after we're done using it?
|
Looks great! One minor comment re: potentially cleaning up the |
|
@kevinushey Thanks for reviewing! I just committed the change. |
|
Something went marginally wrong with the commit as GH thinks you changed 830 lines... Not to worry though. |
|
Oh dear. I made this commit from a Windows machine -- I wonder if that has anything to do with it. |
|
That would do it. Hint: I believe even Windoze has some editors that behave like grownups :) Here it doesn't matter. It's a new file anyway. In general, we've been pretty careful about not mass-committing whitespace changes. (With exception: @kevinushey once did a mass commit as I recall; I recently updated a bunch of headers following @ellert's PR, .... -- but in general that is best avoided). We do have a number of skeletons with mixed tab/spaces in the closet though. But no point going crazy about them just for the heck of it... I'll merge this now. Nice work! |
Sugar cbind with unit tests
The latest
cbindimplementation as discussed toward the bottom of #407.