-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto generation Warnings & Invalid C++ Identifiers (Closes #526 and #387) #528
Conversation
<< std::endl; | ||
if (!function.type().isVoid()) { | ||
ostr() << " return Rcpp::as<" << function.type() << " >" | ||
<< "(__result);" << std::endl; | ||
<< "(RCPP_result_gen_);" << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say drop the trailing underscore as this convention is used elsewhere (e.g. in the attributes implementation) to indicate a C++ member variable.
We now have a merge conflict. Do you want to / have time to work through it? Else I can merge it manually later bu then you don't get the glory ... |
…rning Merge conflict fixes for: ChangeLog inst/NEWS.Rd
Will merge this as nobody cried foul ... |
Hi, might I suggest to drop the leading underscore at all? So instead of writing:
just write:
See our discussion on stackoverflow: http://stackoverflow.com/questions/39291133/how-to-change-header-include-guards-in-rcpp-interfaces/39291326#39291326 and http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier/228797#228797
Best, |
Added Autogeneration Warnings & Invalid C++ Identifiers (Closes #526 and #387)