Feature/new date and datetime vector classes (closes #34) #557

eddelbuettel · 2016-10-16T16:57:54Z

This PR is, in aggregate, not changing anything because the 'new' part is not (yet) activated.

The switch is in the (new) header file inst/include/Rcpp/date_datetime/date_datetime.h which regroups all #include for Date/Datetime and their vector variants.

For now, we typedef the old and existing code in. I think this can be merged as it allows for more testing. We can allow for the usual one-year deprecation (or accelerate it if we feel the change was so trivial).

I use these in my packages RQuantLib, Rblpapi, and anytime -- and want the new and better DatetimeVector (a reclassed `NumericVector) there. T he rev.dep checks I will do may tell me a bit more about other packages using this.

new DateVector & DatetimeVector

tests passed, need to figure out pre-release how to phase this in will run at least one full rev.dep check with this on

eddelbuettel · 2016-10-16T21:33:51Z

@kevinushey @thirdwing @jjallaire : If you could have a look at this one which in essence
-- rename DateVector and DatetimeVector by prefixing old* to them
-- keeps them as the default
-- regroups several related header files in one new directory
-- adds a new variant which was tested in the 3rd of 4 commits and then turned off to have the existing behaviour be the default
All this should be pretty vanilla. We could merge and then rebased for KK's WIP PR.

default is empty string == not set which implies local timezone that is what we had before, and what R does

eddelbuettel · 2016-10-17T16:24:26Z

Running a full rev.dep now with the 'new' classes turned on. All good so far, not a single new failure. Currently at 130 out of 801 with 128 good and two (know, repeat) offenders. Will report back this evening.

Paging @kevinushey @thirdwing @jjallaire for a look at this.

Also: full-blown one-year deprecation, or is this more of a 'same API internal representation change' that we could release as is? Thoughts?

eddelbuettel · 2016-10-18T01:01:51Z

Passed with flying colours; 794 ok, 7 fails of which 4 happened before, 1 happens with release version of Rcpp, 1 lacked an external (web resource) and 1 was spurious (package upgraded while test ran).

eddelbuettel · 2016-10-18T01:03:39Z

So I plan to merge to merge this in short little while.

@kevinushey : comments now or after the fact :)

kevinushey · 2016-10-18T03:17:51Z

inst/include/Rcpp/date_datetime/date_datetime.h

+    // this will not be on by default 
+    #if defined(RCPP_NEW_DATE_DATETIME_VECTORS)
+
+        typedef oldDateVector DateVector;


It looks like the two #ifdef blocks here are identical; is the intention for these to be newDateVector?

kevinushey · 2016-10-18T03:20:08Z

inst/include/Rcpp/date_datetime/newDateVector.h

+    private:
+
+        void setClass() {
+            Rf_setAttrib(*this, R_ClassSymbol, Rf_mkString("Date"));


Although it might not be a problem here, Rf_mkString() should be protected before being passed to Rf_setAttrib() (otherwise if Rf_setAttrib() did any R allocation that "Date" SEXP could be collected)

Sure. I'll assign to Shield<SEXP> first, then call Rf_setAttrib().

eddelbuettel

Will make those changes, thanks!

eddelbuettel · 2016-10-18T10:22:44Z

inst/include/Rcpp/date_datetime/date_datetime.h

+    // this will not be on by default 
+    #if defined(RCPP_NEW_DATE_DATETIME_VECTORS)
+
+        typedef oldDateVector DateVector;


eddelbuettel · 2016-10-18T10:22:44Z

inst/include/Rcpp/date_datetime/newDateVector.h

+    private:
+
+        void setClass() {
+            Rf_setAttrib(*this, R_ClassSymbol, Rf_mkString("Date"));


Sure. I'll assign to Shield<SEXP> first, then call Rf_setAttrib().

@kevinushey

with thanks to @kevinushey

eddelbuettel · 2016-10-18T14:41:15Z

Currently more than 50% done on a second rev.dep run with these changes.

roll Version, Date

eddelbuettel · 2016-10-18T19:24:36Z

Just committed the summary to rcpp-logs: five new build failures. Three of which get fixed with a one-line addition I already made (providing operator double() for the Date class); the other two are RQuantLib and RcppExamples which are both my packages --- and with the planned deprecation I have a year to fix that. More than ample.

So I will merge the PR later today unless somebody screams real loud and real soon . 😀

eddelbuettel added 4 commits Oct 16, 2016

first step towards updated Date{time}Vector

Loading status checks…

3c7f0b6

Date(time)Vector is now oldDate(time)Vector

Loading status checks…

27358a5

for testing, default to 'new' classes

Loading status checks…

fa6dc4e

new DateVector & DatetimeVector

(for now) reset switch for new Datetime(Vector)

Loading status checks…

5b88a1b

tests passed, need to figure out pre-release how to phase this in will run at least one full rev.dep check with this on

eddelbuettel changed the title ~~Feature/new date vector~~ Feature/new date and datetime vector classes Oct 16, 2016

eddelbuettel added 2 commits Oct 17, 2016

allow setting the timezone

Loading status checks…

0187051

default is empty string == not set which implies local timezone that is what we had before, and what R does

complete switch from std::string to const char*

Loading status checks…

0319664

thirdwing approved these changes Oct 17, 2016

View changes

kevinushey reviewed Oct 18, 2016

View changes

eddelbuettel reviewed Oct 18, 2016

View changes

improvements to new Date(time)vector classes

Loading status checks…

6f291db

with thanks to @kevinushey

add operator double() to Date, Datetime

Loading status checks…

90f9487

roll Version, Date

eddelbuettel changed the title ~~Feature/new date and datetime vector classes~~ Feature/new date and datetime vector classes (closes #34) Oct 18, 2016

eddelbuettel merged commit 40dde2f into master Oct 18, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

continuous-integration/travis-ci/push The Travis CI build passed
Details

eddelbuettel deleted the feature/new_date_vector branch Oct 18, 2016

eddelbuettel mentioned this pull request Oct 19, 2016

New DatetimeVector #553

Closed

RcppCore / Rcpp

Feature/new date and datetime vector classes (closes #34) #557

Feature/new date and datetime vector classes (closes #34) #557

eddelbuettel commented Oct 16, 2016 •

edited

eddelbuettel commented Oct 16, 2016

eddelbuettel commented Oct 17, 2016

eddelbuettel commented Oct 18, 2016

eddelbuettel commented Oct 18, 2016

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddelbuettel left a comment

This comment has been minimized.

This comment has been minimized.

eddelbuettel commented Oct 18, 2016

eddelbuettel commented Oct 18, 2016

RcppCore / Rcpp

Sponsor RcppCore/Rcpp

Join GitHub today

Feature/new date and datetime vector classes (closes #34) #557

Feature/new date and datetime vector classes (closes #34) #557

Conversation

eddelbuettel commented Oct 16, 2016 • edited

eddelbuettel commented Oct 16, 2016

eddelbuettel commented Oct 17, 2016

eddelbuettel commented Oct 18, 2016

eddelbuettel commented Oct 18, 2016

This comment has been minimized.

kevinushey Oct 18, 2016 • edited Contributor

This comment has been minimized.

eddelbuettel Oct 18, 2016 Author Member

This comment has been minimized.

kevinushey Oct 18, 2016 Contributor

This comment has been minimized.

eddelbuettel Oct 18, 2016 Author Member

eddelbuettel left a comment

This comment has been minimized.

eddelbuettel Oct 18, 2016 Author Member

This comment has been minimized.

eddelbuettel Oct 18, 2016 Author Member

eddelbuettel commented Oct 18, 2016

eddelbuettel commented Oct 18, 2016

Essential cookies

Always active

Analytics cookies

eddelbuettel commented Oct 16, 2016 •

edited

kevinushey Oct 18, 2016 •

edited

Contributor

eddelbuettel Oct 18, 2016
Author Member

kevinushey Oct 18, 2016
Contributor

eddelbuettel Oct 18, 2016
Author Member

eddelbuettel Oct 18, 2016
Author Member

eddelbuettel Oct 18, 2016
Author Member