change hashing function to return unsigned int #561

Merged
merged 1 commit into from Oct 24, 2016

Projects

None yet

3 participants

@thirdwing
Member

No description provided.

@eddelbuettel
Member

Looks good to me!

@eddelbuettel
Member

Any other thumbs up besides my overused one?

@coatless
Contributor

Change context:

int => unsigned int since the hashing macro is defined to return unsigned int

@coatless
Contributor
coatless commented Oct 24, 2016 edited

Looks like int addr missed a change over in add_value_get_index() within SelfHash.h and add_value() within IndexHash.h

@eddelbuettel
Member

Yes, also see the now closed (because too "jumbo") PR #556

@thirdwing
Member

I have updated the code.

@eddelbuettel
Member

In it goes!

@eddelbuettel eddelbuettel merged commit adae3fe into RcppCore:master Oct 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thirdwing thirdwing deleted the thirdwing:iss391_patch2 branch Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment