Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change hashing function to return unsigned int #561

Merged
merged 1 commit into from
Oct 24, 2016
Merged

change hashing function to return unsigned int #561

merged 1 commit into from
Oct 24, 2016

Conversation

thirdwing
Copy link
Member

No description provided.

@eddelbuettel
Copy link
Member

Looks good to me!

@eddelbuettel
Copy link
Member

Any other thumbs up besides my overused one?

@coatless
Copy link
Contributor

Change context:

int => unsigned int since the hashing macro is defined to return unsigned int

@coatless
Copy link
Contributor

coatless commented Oct 24, 2016 •
edited
Loading

Looks like int addr missed a change over in add_value_get_index() within SelfHash.h and add_value() within IndexHash.h

@eddelbuettel
Copy link
Member

Yes, also see the now closed (because too "jumbo") PR #556

@thirdwing
Copy link
Member Author

I have updated the code.

@eddelbuettel
Copy link
Member

In it goes!

@eddelbuettel eddelbuettel merged commit adae3fe into RcppCore:master Oct 24, 2016
@thirdwing thirdwing deleted the iss391_patch2 branch October 24, 2016 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thirdwing @eddelbuettel @coatless