-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added assignment operators to newDateVector and newDatetimeVector #587
Added assignment operators to newDateVector and newDatetimeVector #587
Conversation
…xed a small bug in their copy construtors.
Might be nice to have a plugin to turn this functionality on as well. |
What are you talking about, exactly? Is it this: edd@max:~/git/rcpp(master)$ git diff
diff --git a/inst/include/Rcpp.h b/inst/include/Rcpp.h
index d365958..fbae1c1 100644
--- a/inst/include/Rcpp.h
+++ b/inst/include/Rcpp.h
@@ -57,6 +57,7 @@
#include <Rcpp/DataFrame.h>
// #define RCPP_NEW_DATE_DATETIME_VECTORS 1
+#define RCPP_NEW_DATE_DATETIME_VECTORS 1
#include <Rcpp/date_datetime/date_datetime.h>
#include <Rcpp/Na_Proxy.h>
edd@max:~/git/rcpp(master)$ That is a single |
I just think it makes it cleaner than relying on the developer for it. Then we can also change how it's implemented behind the scenes (if needed) and change the plugin accordingly to get the right build configuration. |
Very nice that you added unit tests too. |
Calling for reviews or thumbs up/down ... might be nice to get this in before I run a round of tests tomorrow. |
LGTM, although I'm not as familiar with datetime handling (+ the associated traps inherent) with R. |
There is not much too it, but it looks super-confusing. I didn't understand what attributes did eight or nine years ago so the first iteration of these were And what Dan did here was filling gaps I had left as I had, ahem, forgotten that constructors etc don't inherit. So we needed a bit of additional stuff which we now have. |
No description provided.