Feature/update date code #621

Merged
merged 6 commits into from Jan 1, 2017

Projects

None yet

3 participants

@eddelbuettel
Member

src/Date.cpp basically dates from 2010.

It contains some stub code we don't use (ie to load a zonefile) but maybe could / should, but that is for another day.

This PR mostly brings in an update to get to what R uses there. Ultimately I should farm this out but one attempt in repo rapidatetime got suck. Maybe I'll get back to this.

The PR should be harmless. It tests out fine, and the branch also supports tests of RQuantLib which is one the few packages actually using Rcpp::Date a little...

eddelbuettel added some commits Dec 31, 2016
@eddelbuettel eddelbuettel update Date.cpp routines borrowed from R e0d4807
@eddelbuettel eddelbuettel edit comment a little cd5a69b
@eddelbuettel eddelbuettel a new test (which also passes in master)
0c7569a
@eddelbuettel eddelbuettel Merge branch 'master' into feature/update_date_code e26ccdb
@eddelbuettel eddelbuettel reorder changelog
ffbe61d
@codecov-io
codecov-io commented Dec 31, 2016 edited

Current coverage is 76.35% (diff: 64.07%)

Merging #621 into master will decrease coverage by 0.12%

@@             master       #621   diff @@
==========================================
  Files            68         67     -1   
  Lines          4004       4017    +13   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3062       3067     +5   
- Misses          942        950     +8   
  Partials          0          0          

Powered by Codecov. Last update 4a9c6a8...86b36b0

@eddelbuettel
Member

@kevinushey @thirdwing @jjallaire @nathan-russell -- Happy New Year!

In case any one of you has a minute or two to spare, a quick code review here would be appreciated.
Should not bite in any way. New unit test tests in the this branch and in main.

@eddelbuettel eddelbuettel two new tests
86b36b0
@eddelbuettel
Member

And I just added two more.

@kevinushey
Contributor

LGTM!

@kevinushey kevinushey self-assigned this Jan 1, 2017
@kevinushey kevinushey self-requested a review Jan 1, 2017
@kevinushey kevinushey removed their assignment Jan 1, 2017
@eddelbuettel eddelbuettel merged commit f0442a0 into master Jan 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/update_date_code branch Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment