Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/Date.cpp
basically dates from 2010.It contains some stub code we don't use (ie to load a zonefile) but maybe could / should, but that is for another day.
This PR mostly brings in an update to get to what R uses there. Ultimately I should farm this out but one attempt in repo rapidatetime got suck. Maybe I'll get back to this.
The PR should be harmless. It tests out fine, and the branch also supports tests of RQuantLib which is one the few packages actually using
Rcpp::Date
a little...