Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update date code #621

Merged
merged 6 commits into from
Jan 1, 2017
Merged

Feature/update date code #621

merged 6 commits into from
Jan 1, 2017

Conversation

eddelbuettel
Copy link
Member

src/Date.cpp basically dates from 2010.

It contains some stub code we don't use (ie to load a zonefile) but maybe could / should, but that is for another day.

This PR mostly brings in an update to get to what R uses there. Ultimately I should farm this out but one attempt in repo rapidatetime got suck. Maybe I'll get back to this.

The PR should be harmless. It tests out fine, and the branch also supports tests of RQuantLib which is one the few packages actually using Rcpp::Date a little...

@codecov-io
Copy link

codecov-io commented Dec 31, 2016

Current coverage is 76.35% (diff: 64.07%)

Merging #621 into master will decrease coverage by 0.12%

@@             master       #621   diff @@
==========================================
  Files            68         67     -1   
  Lines          4004       4017    +13   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           3062       3067     +5   
- Misses          942        950     +8   
  Partials          0          0          

Powered by Codecov. Last update 4a9c6a8...86b36b0

@eddelbuettel
Copy link
Member Author

@kevinushey @thirdwing @jjallaire @nathan-russell -- Happy New Year!

In case any one of you has a minute or two to spare, a quick code review here would be appreciated.
Should not bite in any way. New unit test tests in the this branch and in main.

@eddelbuettel
Copy link
Member Author

And I just added two more.

@kevinushey
Copy link
Contributor

LGTM!

@kevinushey kevinushey self-assigned this Jan 1, 2017
@kevinushey kevinushey self-requested a review January 1, 2017 22:33
@kevinushey kevinushey removed their assignment Jan 1, 2017
@eddelbuettel eddelbuettel merged commit f0442a0 into master Jan 1, 2017
@eddelbuettel eddelbuettel deleted the feature/update_date_code branch January 1, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants