Feature/bib file #631
Merged
Feature/bib file #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
location in vignettes meant installation from source made it unavailable
thirdwing
approved these changes
Jan 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (unexported)
bib()function supplied the location of theRcpp.bibfile for use by other vignettes (I have at least two other packages using it). However, this did not always work ... because thevignettes/directory does not get processes right when you install from source. So now we put it inbib/Rcpp.biband all is good.This just changes the location, updates the accessor, adds a unit test we can now run, and updates the link in the vignettes.
Should be low key. Review of course still appreciated.