Added support for throwing exceptions without call stacks. #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you see Contributing.md ? |
jimhester
force-pushed
the
exceptions_without_callstacks
branch
from
dc7694c
to
a15ba45
Compare
|
Yes, but not until this was already implemented, since it was already done might as well look at the code |
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
=======================================
Coverage 92.91% 92.91%
=======================================
Files 65 65
Lines 3303 3303
=======================================
Hits 3069 3069
Misses 234 234
Continue to review full report at Codecov.
|
|
Meant to reopen this earlier after we all seemed to have reached consensus on #664, but got sidetracked. |
eddelbuettel
approved these changes
Apr 10, 2017
|
This looks fine to me. Any other takers? |
|
+1 |
eddelbuettel
added a commit
that referenced
this pull request
Apr 11, 2017
commit 43e53b0 Merge: 886f5df a15ba45 Author: Dirk Eddelbuettel <edd@debian.org> Date: Tue Apr 11 13:20:10 2017 -0500 Merge pull request #663 from jimhester/exceptions_without_callstacks Added support for throwing exceptions without call stacks. commit a15ba45 Author: Jim Hester <james.f.hester@gmail.com> Date: Mon Apr 3 16:11:24 2017 -0400 Added support for throwing exceptions without call stacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently no way to generate an exception from Rcpp which does not have an attached R (and cpp) call stacks. This extra information can be confusing for users, so it is useful to be able to disable it if desired (like
stop(call. = FALSE)does in R code.This could be implemented by providing overloaded
forward_exception_to_r()andexception_to_r_condition()functions forRcpp::exceptions, but I felt like it made the intention more clear to define new functions instead.