Remove name for unused arguments

[krlmlr]

with (void)arg; in the function's body.

[codecov-io]

Codecov Report

Merging #672 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   92.91%   92.91%   -0.01%     
==========================================
  Files          65       65              
  Lines        3303     3302       -1     
==========================================
- Hits         3069     3068       -1     
  Misses        234      234

Impacted Files	Coverage Δ
src/Rcpp_init.cpp	100% <ø> (ø)	⬆️
src/attributes.cpp	98.9% <100%> (-0.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21d8388...93dfa96. Read the comment docs.

[kevinushey]

LGTM, although I wonder about a couple of the non-used arguments (it seems like they should likely be used?)

[kevinushey]

Oh, it looks like a bunch of classes within attributes.cpp have the same interface but some don't need to handle the accepted arguments.

[jjallaire]

Those can just be changed to have only the type in the signature rather than the type and variable name then they should pass.

…

On Thu, Apr 13, 2017 at 12:40 PM, Kevin Ushey ***@***.***> wrote: Oh, it looks like a bunch of classes within attributes.cpp have the same interface but some don't need to handle the accepted arguments. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#672 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXxzH6BFi0McN3r4CORnKRVUI6mIBdks5rvlAXgaJpZM4M8mTQ> .

[eddelbuettel]

This one looks much better now too. Will pull it in, and then start another rev.dep. Don't expect anything though.

[eddelbuettel]

Woot. And just installed with ccache g++ -I/usr/share/R/include -DNDEBUG -I../inst/include/ -fpic -g -O3 -Wall -pipe -pedantic -Wextra -c. That's first.

Thanks for that. I am sure I will have to remove -Wextra from Makevars when compiling other packages but it is rather nice to have Rcpp squeaky clean.

[krlmlr]

You're welcome. I tend to use a package-local Makevars (with a corresponding .Rprofile): krlmlr/scriptlets@8467934.

[eddelbuettel]

Not familiar with those hooks. Does it require devtools, or would standard R tools adhere to them too? In other words would Writing R Extensions describe this?

[krlmlr]

Works with base R, also in R CMD INSTALL. R_MAKEVARS_USER is described in R-admin.

[eddelbuettel]

Nice! I'll follow up on that. I tend to be aware of what is in R-exts, but they trick me now by hiding more stuff in R-inst and R-admin.