New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh tinyformat with May 2016 header, retain local modifications (close #673) #674

Merged
merged 1 commit into from Apr 16, 2017

Conversation

Projects
None yet
3 participants
@coatless
Contributor

coatless commented Apr 14, 2017

This is needed in order to enable variadic templates under C++11 for the exception message upgrade.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Apr 14, 2017

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          65       65           
  Lines        3302     3302           
=======================================
  Hits         3068     3068           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9e391...0c23876. Read the comment docs.

Codecov Report

Merging #674 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          65       65           
  Lines        3302     3302           
=======================================
  Hits         3068     3068           
  Misses        234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9e391...0c23876. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 14, 2017

Member

I'll noodle it through the rev.depper tomorrow.

Member

eddelbuettel commented Apr 14, 2017

I'll noodle it through the rev.depper tomorrow.

@coatless coatless referenced this pull request Apr 15, 2017

Closed

better error messages #184

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Apr 16, 2017

Member

Passed revdep cleanly, see no issues -- merging

Member

eddelbuettel commented Apr 16, 2017

Passed revdep cleanly, see no issues -- merging

@eddelbuettel eddelbuettel merged commit 052089b into RcppCore:master Apr 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@coatless coatless deleted the coatless:feature/refresh-tinyformat branch Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment