Reduce -Wconversion warnings for date-time code #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coatless
reviewed
May 5, 2017
| @@ -127,7 +127,7 @@ namespace Rcpp { | |||
| // update m_tm based on m_d | |||
| void update_tm() { | |||
| if (R_FINITE(m_d)) { | |||
| time_t t = 24*60*60 * m_d; // (fractional) days since epoch to seconds since epoch | |||
| time_t t = (time_t)(24*60*60 * m_d); // (fractional) days since epoch to seconds since epoch | |||
There was a problem hiding this comment.
I think you may need to use a static_cast<time_t>() in place of the c-style / regular cast.
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 66 66
Lines 3511 3511
=======================================
Hits 3152 3152
Misses 359 359Continue to review full report at Codecov.
|
|
This looks good to me. It would help if we had more tests for some of the rounding etc issues, but blame for that is mostly on me. |
thirdwing
approved these changes
May 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Rcpp-devel.