-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create src/init.c for skeleton #692
Conversation
Yes I think |
I think I agree. And if/when it does, we need to remove it from here as well. Also need to add |
Codecov Report
@@ Coverage Diff @@
## master #692 +/- ##
==========================================
- Coverage 89.77% 89.72% -0.06%
==========================================
Files 66 66
Lines 3511 3523 +12
==========================================
+ Hits 3152 3161 +9
- Misses 359 362 +3
Continue to review full report at Codecov.
|
@jjallaire I only glanced at
|
I can take a look sometime later this week or next. The biggest issue I see is that if users have a file other than init.c which includes a package initialization function we'll be adding another one (which will break their compilation). Note this will happen on their local system rather than on CRAN so it's recoverable, but still ugly. Another possibility would be to scan for package init functions as part of our normal scanning and then only write init.c if there is no package init function. |
Point well taken on files not-named |
I'll fold this to tick off another micro-issue. |
This lets
Rcpp.package.skeleton()
createsrc/init.c
(by making the required call).Should
compileAttributes()
do that too?