Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Protect function argument to rcpp_set_stack_trace() #706
which may be gc-ed otherwise.
I was unable to create a reproducible example for this problem, but I have two stack traces from test runs for dplyr with valgrind and gctorture enabled that indicate that this may be the source of a problem. I'm not seeing these errors anymore after applying this fix.
@@ Coverage Diff @@ ## master #706 +/- ## ======================================= Coverage 89.57% 89.57% ======================================= Files 66 66 Lines 3588 3588 ======================================= Hits 3214 3214 Misses 374 374
Thanks for catching this! I don't think this is quite the right change, though.
Normally, we should be able to operate under the assumption that
It looks to me like the real issue here is that the
And so the returned