New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Rcpp compile and install on haiku-os #708

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@armgong
Contributor

armgong commented Jun 5, 2017

make Rcpp compile and install on haiku-os , but don't know how to write unit test

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jun 5, 2017

Member

Looks good. And "we have your word" that this helps on Haiku-OS as we cannot test?

Member

eddelbuettel commented Jun 5, 2017

Looks good. And "we have your word" that this helps on Haiku-OS as we cannot test?

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 5, 2017

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          66       66           
  Lines        3588     3588           
=======================================
  Hits         3214     3214           
  Misses        374      374
Impacted Files Coverage Δ
src/api.cpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0725728...efb6a9e. Read the comment docs.

codecov-io commented Jun 5, 2017

Codecov Report

Merging #708 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          66       66           
  Lines        3588     3588           
=======================================
  Hits         3214     3214           
  Misses        374      374
Impacted Files Coverage Δ
src/api.cpp 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0725728...efb6a9e. Read the comment docs.

@eddelbuettel eddelbuettel merged commit 4d982f7 into RcppCore:master Jun 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@armgong

This comment has been minimized.

Show comment
Hide comment
@armgong

armgong Jun 5, 2017

Contributor

run unit test on haiku-os and R 3.3.1 gcc 5.4.0 , one unit test file crash R (runit.wrap.R will try find what cause R crash ) , all others success.

Rcpp-unitTests.txt

Contributor

armgong commented Jun 5, 2017

run unit test on haiku-os and R 3.3.1 gcc 5.4.0 , one unit test file crash R (runit.wrap.R will try find what cause R crash ) , all others success.

Rcpp-unitTests.txt

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jun 5, 2017

Member

I don't follow. I see

Number of test functions: 558
Number of errors: 0
Number of failures: 0

Member

eddelbuettel commented Jun 5, 2017

I don't follow. I see

Number of test functions: 558
Number of errors: 0
Number of failures: 0

@armgong

This comment has been minimized.

Show comment
Hide comment
@armgong

armgong Jun 5, 2017

Contributor

this is one crash (in runit.wrap.R) and I have to remove this file from tests
Executing test function test.wrap.map.string.double ...
*** caught segfault ***
address 0x12574d2dfb0, cause 'memory not mapped'
An irrecoverable exception occurred. R is aborting now ...
Segmentation violation

Contributor

armgong commented Jun 5, 2017

this is one crash (in runit.wrap.R) and I have to remove this file from tests
Executing test function test.wrap.map.string.double ...
*** caught segfault ***
address 0x12574d2dfb0, cause 'memory not mapped'
An irrecoverable exception occurred. R is aborting now ...
Segmentation violation

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Jun 5, 2017

Member

Oh I see. The string library implementation may be different.

But yes, by all means please investigate. And no hurry.

Member

eddelbuettel commented Jun 5, 2017

Oh I see. The string library implementation may be different.

But yes, by all means please investigate. And no hurry.

@armgong

This comment has been minimized.

Show comment
Hide comment
@armgong

armgong Jun 5, 2017

Contributor

I will investigate it in weekend ,thanks a lot

Contributor

armgong commented Jun 5, 2017

I will investigate it in weekend ,thanks a lot

eddelbuettel added a commit that referenced this pull request Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment