New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't declare unused arguments #716

Merged
merged 1 commit into from Jun 18, 2017

Conversation

Projects
None yet
3 participants
@krlmlr
Contributor

krlmlr commented Jun 17, 2017

to support -Wextra.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jun 17, 2017

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          66       66           
  Lines        3588     3588           
=======================================
  Hits         3214     3214           
  Misses        374      374
Impacted Files Coverage Δ
inst/include/Rcpp/exceptions.h 50% <ø> (ø) ⬆️
src/attributes.cpp 98.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec267a...f7d7f24. Read the comment docs.

codecov-io commented Jun 17, 2017

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   89.57%   89.57%           
=======================================
  Files          66       66           
  Lines        3588     3588           
=======================================
  Hits         3214     3214           
  Misses        374      374
Impacted Files Coverage Δ
inst/include/Rcpp/exceptions.h 50% <ø> (ø) ⬆️
src/attributes.cpp 98.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ec267a...f7d7f24. Read the comment docs.

@eddelbuettel

Looks good to me

@eddelbuettel eddelbuettel merged commit b042d09 into RcppCore:master Jun 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@krlmlr krlmlr deleted the krlmlr:b-unused branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment