Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate tinyformat #791
Update tinyformat #791
Conversation
|
I'll probably merge Kevin's PR next, and if "just merge" this we get nasty graph. Shall we bother with rebasing or should I just squash this in? Undecided so far if it needs rev.dep run by itself. Maybe ... |
|
I can rebase if it helps. Still need to update |
|
I like cleanly separated paths when I do Myself, I mostly get lost with rebase. I think I did it right just once or twice. So squash would be an easy out. But if you can "graft" your few commits behind Kevin's (once I merge them in an hour or two to three) then I'd be happy in a typically nerdy type-A way that does really matter :) |
|
The Answer seems to be no:
|
| //------------------------------------------------------------------------------ | ||
| // Implementation details. | ||
| #include <algorithm> | ||
| #include <cassert> |
coatless
Dec 20, 2017
•
Contributor
Could the #include<cassert> be moved to the #ifndef TINYFORMAT_ASSERT in upstream tidyformat?
Could the #include<cassert> be moved to the #ifndef TINYFORMAT_ASSERT in upstream tidyformat?
|
Merged other PR, wrapped this up a local package and started a new reverse depends check. Mine are still serial (working on that ...) so it'll be tomorrow. Plenty of time for you to rebase if you feel like it. |
Fixes #786.