Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
shielding #789 behind a new #define to effectively disable it now #802
Sure, we could. So far I figured @lionel- 's PR was somewhat limited so I could just leave it in place, "protect" it (or us ;-) ) from it and give him a chance to revisit in time.
See the diff. Your PR affected other areas, and things generally turned sour ... on systems other than Linux. I spent two days cleaning this and am not too interested in discussions of the "in theory this should have worked" type because I have ample evidence that "in practice" this didn't. Part of it may be R. We don't quite know.
But now is neither the time to take chance, nor for experimentation. Let's get a working 0,12,15 out the door.