More thorough use of storage policy in Vector internals

[romainfrancois]

This was a but more than I anticipated. Probably not exhaustive. but it makes the tests pass.

// [[Rcpp::export]]
int CharacterVectorNoProtect(Vector<STRSXP, NoProtectStorage> s){
    s[0] = "";
    return s.size();
}

// [[Rcpp::export]]
CharacterVector CharacterVectorNoProtect_crosspolicy(Vector<STRSXP, NoProtectStorage> s){
    CharacterVector s2(1) ;
    s2[0] = s[0];
    return s;
}

// [[Rcpp::export]]
List ListNoProtect_crosspolicy(Vector<VECSXP, NoProtectStorage> data){
    List data2(1) ;
    data2[0] = data[0];
    return data2;
}

[eddelbuettel]

I see this failing on Travis. At least this test has an issue:

1 Test Suite : 
Rcpp Unit Tests - 589 test functions, 0 errors, 1 failure
FAILURE in test.DataFrame.CreateTwo.stringsAsFactors: Error in checkEquals(createTwoStringsAsFactors(), DF, msg = "DataFrame create2 stringsAsFactors = false") : 
  Names: 2 string mismatches
DataFrame create2 stringsAsFactors = false

Can you take another look?

[eddelbuettel]

Looks like a name attribute may not get dropped ?

R> library(Rcpp)
R> sourceCpp("~/git/rcpp/inst/unitTests/cpp/DataFrame.cpp")
R>         DF <- data.frame(a=1:3, b=c("a","b","c"), stringsAsFactors = FALSE )
R> RUnit::checkEquals( createTwoStringsAsFactors(), DF, msg = "DataFrame create2 stringsAsFactors = false")
Error in RUnit::checkEquals(createTwoStringsAsFactors(), DF, msg = "DataFrame create2 stringsAsFactors = false") : 
  Names: 2 string mismatches
DataFrame create2 stringsAsFactors = false
R> DF
  a b
1 1 a
2 2 b
3 3 c
R> createTwoStringsAsFactors()
  X1.3 c..a....b....c..
1    1                a
2    2                b
3    3                c
R> 

[romainfrancois]

should be better now.

[eddelbuettel]

Yes, indeed -- thanks.

I happened to have run reverse depends on a machine this week, so I turned on a new one. We'll know in a few hours if that shows something unexpected.

[eddelbuettel]

No issues, so merging.

[romainfrancois]

Great thanks. I’ll probably find out more of these if I start using alternative storage policies.

[eddelbuettel]

BTW I have had dplyr bomb for the last little while but I guess you guys know that anyway as it currently bombs at CRAN too ...

See eg here for a summary. I have logs if you need them.

[romainfrancois]

A new version has been sent to cran, two weeks ago.

[eddelbuettel]

Right. I even knew that. RcppArmadillo sat in the same 'inspect' corner for over a week too.