Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [[Rcpp::init]] attribute for registering functions to run on package init #903

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

jjallaire
Copy link
Member

Addresses #902

@eddelbuettel
Copy link
Member

Man you are fast :)

DESCRIPTION Outdated
@@ -1,6 +1,6 @@
Package: Rcpp
Title: Seamless R and C++ Integration
Version: 0.12.18.2
Version: 0.12.18.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.3 is already used in the other open PR. Can you maybe cherry-pick over here or accomodate otherwise?

my_package_init(dll);
}
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff!

@jjallaire
Copy link
Member Author

Got rid of the version bump

@eddelbuettel
Copy link
Member

Could have made .4 too. Wonder if we need to this, maybe via the most package we have for unit tests? Haven't looked at that one in a while ...

@romainfrancois
Copy link
Contributor

That looks great.

@eddelbuettel eddelbuettel merged commit 404e1ef into master Sep 18, 2018
@eddelbuettel eddelbuettel deleted the feature/rcpp-init-attribute branch September 18, 2018 22:50
@eddelbuettel eddelbuettel mentioned this pull request Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants