Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [[Rcpp::init]] attribute for registering functions to run on package init #903

Merged
merged 2 commits into from Sep 18, 2018

Conversation

@jjallaire
Copy link
Member

@jjallaire jjallaire commented Sep 18, 2018

Addresses #902

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Sep 18, 2018

Man you are fast :)

DESCRIPTION Outdated
@@ -1,6 +1,6 @@
Package: Rcpp
Title: Seamless R and C++ Integration
Version: 0.12.18.2
Version: 0.12.18.3

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 18, 2018
Member

.3 is already used in the other open PR. Can you maybe cherry-pick over here or accomodate otherwise?

my_package_init(dll);
}
```

This comment has been minimized.

@eddelbuettel

eddelbuettel Sep 18, 2018
Member

Lovely stuff!

@jjallaire
Copy link
Member Author

@jjallaire jjallaire commented Sep 18, 2018

Got rid of the version bump

@eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Sep 18, 2018

Could have made .4 too. Wonder if we need to this, maybe via the most package we have for unit tests? Haven't looked at that one in a while ...

@romainfrancois
Copy link
Contributor

@romainfrancois romainfrancois commented Sep 18, 2018

That looks great.

@eddelbuettel eddelbuettel merged commit 404e1ef into master Sep 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@eddelbuettel eddelbuettel deleted the feature/rcpp-init-attribute branch Sep 18, 2018
@eddelbuettel eddelbuettel mentioned this pull request Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.