Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd [[Rcpp::init]] attribute for registering functions to run on package init #903
Conversation
|
Man you are fast :) |
DESCRIPTION
Outdated
| @@ -1,6 +1,6 @@ | |||
| Package: Rcpp | |||
| Title: Seamless R and C++ Integration | |||
| Version: 0.12.18.2 | |||
| Version: 0.12.18.3 | |||
eddelbuettel
Sep 18, 2018
Member
.3 is already used in the other open PR. Can you maybe cherry-pick over here or accomodate otherwise?
.3 is already used in the other open PR. Can you maybe cherry-pick over here or accomodate otherwise?
| my_package_init(dll); | ||
| } | ||
| ``` | ||
|
|
eddelbuettel
Sep 18, 2018
Member
Lovely stuff!
Lovely stuff!
|
Got rid of the version bump |
|
Could have made .4 too. Wonder if we need to this, maybe via the most package we have for unit tests? Haven't looked at that one in a while ... |
|
That looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Addresses #902