Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
allow the syntax Matrix mat(no_init(n,nc)) #904
Are the test failures related to this PR? See https://github.com/RcppCore/Rcpp/pull/904/files?utf8=%E2%9C%93&diff=split&w=1 to hide the whitespace-only changes.
I open an issue when i am onto something, and it does not appear trivial to do the work immediately. For example with the Rcpp::init the other day.
Otherwise pull request are typically a much better format as they offer a way to discuss and bind additional context.
I did some testing, but then my time is a limited resource too so i tend to trust travis for the rest.
As for reverse dependency tests, i’m clearly not going to do it to test something that previously failed to compile before the changes.
This repo and project operate with a set of suggested rules which have worked well for us in the past. Issue tickets first is one of those, and we would appreciate it if you could play along just like ever other repeat contributor does.
So for this, please cherry-pick in this commit of mine into your branch and hence this PR: c9da803