Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the files scanned for attributes in the C locale #912

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@jjallaire
Copy link
Member

jjallaire commented Oct 8, 2018

Should provide more stable output of generated code in RcppExports.cpp across systems.

Change originally suggested in this discussion: #878

See additional discussion here: apache/arrow#2711 (comment)

@romainfrancois We might want to test this on your system to confirm that you get stable output in both package build incantations.

@wesm Hopefully this will provide final resolution to this issue (although there might be one final churn while migrating into the stable form).

@eddelbuettel eddelbuettel merged commit b7dc5f1 into master Oct 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/stable-attributes-listing branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.