Sort the files scanned for attributes in the C locale #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut across systems
kevinushey
approved these changes
Oct 8, 2018
eddelbuettel
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should provide more stable output of generated code in RcppExports.cpp across systems.
Change originally suggested in this discussion: #878
See additional discussion here: apache/arrow#2711 (comment)
@romainfrancois We might want to test this on your system to confirm that you get stable output in both package build incantations.
@wesm Hopefully this will provide final resolution to this issue (although there might be one final churn while migrating into the stable form).