Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Follow system theme immediately #1942

Merged
merged 3 commits into from
Jun 29, 2024
Merged

Conversation

snehithssv
Copy link
Contributor

Added didChangeAppLifecycleState @ovverride for theme update for triggering theme-change.

@snehithssv
Copy link
Contributor Author

Resolves #1877

@oSumAtrIX oSumAtrIX requested a review from Aunali321 June 10, 2024 11:11
@snehithssv snehithssv changed the title Resolves #1877 (bug: Manager doesn't follow system theme settings immediately) fix(UI): #1877 (bug: Manager doesn't follow system theme settings immediately) Jun 10, 2024
@validcube validcube linked an issue Jun 10, 2024 that may be closed by this pull request
4 tasks
@validcube validcube changed the title fix(UI): #1877 (bug: Manager doesn't follow system theme settings immediately) fix: Manager doesn't follow system theme settings immediately Jun 10, 2024
@Ushie Ushie changed the title fix: Manager doesn't follow system theme settings immediately fix: Follow system theme immediately Jun 10, 2024
@oSumAtrIX oSumAtrIX merged commit 694f2a9 into ReVanced:dev Jun 29, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jun 30, 2024
# [1.21.0-dev.6](v1.21.0-dev.5...v1.21.0-dev.6) (2024-06-30)

### Bug Fixes

* Add missing import to patch options field ([d60f9aa](d60f9aa))
* Follow system theme immediately ([#1942](#1942)) ([694f2a9](694f2a9))
* Handle selecting files and folders for patch options correctly ([#1941](#1941)) ([b26760b](b26760b))
* Increase dashboard RefreshIndicator edge offset ([#1859](#1859)) ([232b702](232b702))
* Select previously applied patches when loading patch selection ([#1865](#1865)) ([7ef8f04](7ef8f04))
* Unsupported patch toast says "patchItem.unsupportedPatchVersion" ([#2011](#2011)) ([3209c0e](3209c0e))

### Features

* Save last patched app ([#1414](#1414)) ([7720408](7720408))
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
# [1.21.0](v1.20.1...v1.21.0) (2024-07-29)

### Bug Fixes

* Add missing import to patch options field ([d60f9aa](d60f9aa))
* Adjust scroll from clipping children form fields in `AlertDialog` from `showSourcesDialog` ([#1782](#1782)) ([bbeb836](bbeb836))
* Cache external API calls  ([#1911](#1911)) ([2c3e2e6](2c3e2e6))
* Change problematic translation string ([6b03f3a](6b03f3a))
* Correct architecture to armeabi-v7a ([63c6412](63c6412))
* Download latest integrations non-pre-release ([4a72267](4a72267))
* Follow language update immediately ([#1944](#1944)) ([c13827e](c13827e))
* Follow system theme immediately ([#1942](#1942)) ([694f2a9](694f2a9))
* Handle selecting files and folders for patch options correctly ([#1941](#1941)) ([b26760b](b26760b))
* Increase dashboard RefreshIndicator edge offset ([#1859](#1859)) ([232b702](232b702))
* Patching Screen draw-behind Navigation Bar ([#1945](#1945)) ([f1b25d0](f1b25d0))
* Restore consistency with the app ([ea9654e](ea9654e))
* SecurityException when patching application ([#1856](#1856)) ([e0a6de2](e0a6de2))
* Select previously applied patches when loading patch selection ([#1865](#1865)) ([7ef8f04](7ef8f04))
* Unable to install application regardless of preference ([c7627ce](c7627ce))
* Unsupported patch toast says "patchItem.unsupportedPatchVersion" ([#2011](#2011)) ([3209c0e](3209c0e))
* Update dialog shows dev version & loading gets stuck in certain circumstances ([#1792](#1792)) ([fc52560](fc52560))

### Features

* Add ability to set `null` in patch options ([#1947](#1947)) ([5c68d51](5c68d51))
* Include primary architecture in external search ([#2068](#2068)) ([23690a9](23690a9))
* open browser when clicking on changelog link ([bc300d8](bc300d8))
* Save last patched app ([#1414](#1414)) ([7720408](7720408))
* Support patching on ARMv7a ([a766352](a766352))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Manager doesn't follow system theme settings immediately
4 participants