fix: exclude x86 aapt2 binary from release builds

[kitadai31]

Add abiFilters to exclude x86 native libraries for release builds.
Because the x86 aapt2 binary causes crash on x86 devices.

Reason

Flutter doesn't support x86 for release build.
So, when running Flutter apps on x86 devices, usually armv7 libflutter.so and libapp.so are loaded through ARM emulation.
flutter/flutter#9253 (comment)

However, If the app contains one or more x86 libs, Android OS only loads native libraries in libs/x86/.
Then the app can't load libflutter.so and crashes with UnsatisfiedLinkError.
Therefore, the x86 aapt2 binary has no reason to exist in release builds.

Also, this reduces APK size by 3MB.

Test Result

Unfortunately, I don't have any actual x86 devices, so I tested on an Android Emulator which supports ARM emulation.

Before removing x86 aapt2:

08-09 18:48:57.738 E/AndroidRuntime( 2254): FATAL EXCEPTION: main
08-09 18:48:57.738 E/AndroidRuntime( 2254): Process: app.revanced.manager.flutter, PID: 2254
08-09 18:48:57.738 E/AndroidRuntime( 2254): java.lang.RuntimeException: Unable to start activity ComponentInfo{app.revanced.manager.flutter/app.revanced.manager.flutter.MainActivity}:java.lang.RuntimeException: java.util.concurrent.ExecutionException: 
java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/data/app/app.revanced.manager.flutter-AKmflX556hph5RlNTj84VA==/base.apk"],nativeLibraryDirectories=[/data/app/app.revanced.manager.flutter-AKmflX556hph5RlNTj84VA==/lib/x86, /data/app/app.revanced.manager.flutter-AKmflX556hph5RlNTj84VA==/base.apk!/lib/x86, /system/lib, /system/vendor/lib]]] couldn't find "libflutter.so"

I can't open ReVanced Manager as couldn't find "libflutter.so"

After removing x86 aapt2:

Manager works with ARM emulation

[kitadai31]

Or is it better to just delete android/app/src/main/jniLibs/x86/libaapt2.so ?

[validcube]

🔼 Looks fine to me.