feat: Select bundle type before adding bundle

[Ushie]

closes #1250

2023-11-12.03-14-45.mp4

• Remove horizontal padding in the AlertDialog

[CnC-Robert]

Why is the remote option at the bottom? Shouldn't it be the primary option?

[Ushie]

That's how it is in the design

[CnC-Robert]

The design isn't perfect, remote option at the top would make more sense to me

[Ushie]

@PalmDevs what do you think?

[PalmDevs]

What Robert said is okay, you can put it at the top.

[PalmDevs]

Also does Compose not have list dialogs? The ripple effect looks really wonky here when you select an option. Maybe try removing the dialog's padding?

[Ushie]

The screen recording is outdated, the dialog has been updated to resemble the design as much as possible

[oSumAtrIX]

This change bundle type setting should not exist. Once you select the bundle type and add it, its there. You may edit metadata such as name, but not the ty pe It's like creating a file in windows, but now you decided it should be a folder. Additionally the fact that this setting has absolutely no purpose complements this

[PalmDevs]

This change bundle type setting should not exist. Once you select the bundle type and add it, its there. You may edit metadata such as name, but not the ty pe It's like creating a file in windows, but now you decided it should be a folder. Additionally the fact that this setting has absolutely no purpose complements this

It's gonna have to be this way until we get integrations and patched merged together, since you'd need to have 2 fields available for both of the files, but then you only need to input a URL.

Showing both of them wouldn't make much sense either, the user can get confused on why the field is there and why it's disabled even after entering a bundle URL.

And showing only one of them until a file is selected can also still cause confusion, because if the user just finishes downloading a patches.jar file, picks it from storage, and then sees another field, it's likely they'll be frustrated because this information was never presented to them.

If you have any other design suggestions, please send them here. I can also make it a "remote" bundle by default after clicking the + FAB, but the dialog would still need to be there so the user can start picking local files after clicking on the Bundle type item in the Import patch bundle screen and selecting the local choice.

[Ushie]

He meant about editing an existing bundle, not adding a new one, just commented outside of review mistakenly

[PalmDevs]

Then what he said is okay to me 👍

[oSumAtrIX]

Currently, the popup leaves the choice to the user to choose what type of bundle they want. This is problematic as one will not know what type to choose. A better approach is to let the system choose the correct type automatically. Szenario:

1. The user downloads a patches.jar file
2. The user opens ReVanced Manager, clicks +, and is presented with a popup with a textbox and the option to choose from storage.
3. Because the user initially downloaded a file, they will implicitly know to select it.
4. The system reads it and adds it as a "Local" bundle

Szenario two:

1. The user is sent a URL
2. The user opens ReVanced Manager, clicks +, and is presented with a popup with a textbox and the option to choose from storage.
3. Because the user initially was sent a URL, they implicitly know to paste it into the textbox
4. The system reads it and adds it as a "Remote" or "Local" bundle (depending on the protocol, it can be a file:// or http:// URL, for example, so you can think about supporting a range of protocols or just HTTP if its easier at first)

This eliminates the user having to determine and choose the correct type and avoids the potential mistake of choosing the incorrect type alone because the system does it for them.

A good UI could present "Chose file" and "Paste URL." If the user clicks on "Paste URL," it will automatically try to parse the clipboard or offer an input text box. Note how we replaced "Local" and "Remote" with "Chose file" and "Paste URL".

[Axelen123]

Should be good after this final change.