docs(readme): add documentation and minor fixes #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase your PR ontop of the latest dev commit |
|
Apparently is already. |
|
It reverts changes of d121861 |
oSumAtrIX
requested changes
Sep 13, 2023
Well, thats what they PR'd. Not sure about their intention though. |
|
Their changes are based on main, but PR targets dev |
|
The PR source branch is based on |
|
Im a dumbass. I edited the dev branch (that wasn't synced) and then copy/pasted to the dev branch while synced |
|
Simply drop the last commit and commit a new one. |
|
I dont use git so i couldn't figure how to drop a commit. But the current file changes should be good now |
validcube
changed the title
validcube
changed the title
validcube
approved these changes
Sep 16, 2023
|
Thank you @validcube ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #962