Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not crash when selecting an APK from storage #1768

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

TheAabedKhan
Copy link
Member

I couldn't reproduce the issue. However, from my research, I found that providing the mimeTypesFilter to the file picker solves the issue. This also allows us to remove the fileExtensionsFilter.

I couldn't reproduce the issue. However, from my research, I found that providing the `mimeTypesFilter` to the file picker solves the issue. This also allows us to remove the `fileExtensionsFilter`.
@TheAabedKhan TheAabedKhan linked an issue Mar 17, 2024 that may be closed by this pull request
4 tasks
@Ushie Ushie changed the title fix: Rare crashes when selecting apk from storage fix: Do not crash when selecting an APK from storage Apr 5, 2024
@Ushie Ushie merged commit 8564c1a into ReVanced:dev Apr 5, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
# [1.20.0-dev.1](v1.19.4-dev.7...v1.20.0-dev.1) (2024-04-05)

### Bug Fixes

* Do not crash when selecting an APK from storage ([#1768](#1768)) ([8564c1a](8564c1a))

### Features

* Improve language update settings ([#1838](#1838)) ([f9e6ef3](f9e6ef3))
github-actions bot pushed a commit that referenced this pull request Apr 5, 2024
# [1.20.0](v1.19.3...v1.20.0) (2024-04-05)

### Bug Fixes

* disable proguard obfuscation ([401646a](401646a))
* Do not crash when selecting an APK from storage ([#1768](#1768)) ([8564c1a](8564c1a))
* Don't translation ReVanced repository ([c265794](c265794))
* Ensure safe area usage in Changelogs Modal Bottom Sheet ([#1772](#1772)) ([c981cb4](c981cb4))
* Pre-releases changelog being shown ([#1767](#1767)) ([add49e1](add49e1))
* Replace Spacer with Expanded to avoid overflow ([#1791](#1791)) ([6f70a07](6f70a07))
* Set text colour on dropdown menu for Custom Value ([966796d](966796d)), closes [#1584](#1584)
* **ui:** Support free-scroll and auto-scroll for the installer logs ([#1736](#1736)) ([#1836](#1836)) ([025ff52](025ff52))

### Features

* Improve language update settings ([#1838](#1838)) ([f9e6ef3](f9e6ef3))
@TheAabedKhan TheAabedKhan deleted the storage-crash branch April 13, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revanced Manager Crash
2 participants