fix: Ensure safe area usage in Changelogs Modal Bottom Sheet (1741) #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue ReVanced#1741, where the *Changelogs Modal Bottom Sheet* was overlapping with the *Notifications Bar* (system intrusion). By adding the `useSafeArea` property set to `true` when invoking `showModalBottomSheet`. we enhance the user experience and readability by preventing text within the Changelogs bottom modal sheet from overlapping behind the Notifications Bar. This change ensures that reading text is now significantly easier and clearer.
validcube
changed the title
validcube
approved these changes
Mar 18, 2024
⚒️ Build status✅ Succeeded build on ffbe562. Details: 8325198312! ⚙️ Workflow run configuration
|
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Mar 23, 2024
## [1.19.4-dev.2](v1.19.4-dev.1...v1.19.4-dev.2) (2024-03-23) ### Bug Fixes * Ensure safe area usage in Changelogs Modal Bottom Sheet ([#1772](#1772)) ([c981cb4](c981cb4))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 5, 2024
# [1.20.0](v1.19.3...v1.20.0) (2024-04-05) ### Bug Fixes * disable proguard obfuscation ([401646a](401646a)) * Do not crash when selecting an APK from storage ([#1768](#1768)) ([8564c1a](8564c1a)) * Don't translation ReVanced repository ([c265794](c265794)) * Ensure safe area usage in Changelogs Modal Bottom Sheet ([#1772](#1772)) ([c981cb4](c981cb4)) * Pre-releases changelog being shown ([#1767](#1767)) ([add49e1](add49e1)) * Replace Spacer with Expanded to avoid overflow ([#1791](#1791)) ([6f70a07](6f70a07)) * Set text colour on dropdown menu for Custom Value ([966796d](966796d)), closes [#1584](#1584) * **ui:** Support free-scroll and auto-scroll for the installer logs ([#1736](#1736)) ([#1836](#1836)) ([025ff52](025ff52)) ### Features * Improve language update settings ([#1838](#1838)) ([f9e6ef3](f9e6ef3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Fix: Ensure Safe Area Usage in Changelogs Modal Bottom Sheet (1741)
This PR closes #1741.
Overview
The Changelogs Modal Bottom Sheet overlaps with the Notifications Bar (system intrusion) because the Modal Sheet is not constrained by a safe area.
Safe Areaconstraints are not correctly applied on the ChangelogsModal Bottom Sheet.showModalBottomSheet, are called without theuseSafeAreaproperty, causing a visual overlap with the notifications bar, when the modal sheet occupies the whole screen.📓 Description
This pull request solves the overlap issue by adding the missing useSafeArea parameter (to true) on the
showModalBottomSheetmethod invocation.✍🏼 Changes Made
HomeViewModeluseSafeAreawithtrue🦯 Testing
📋 Notes & References
🔬 Reviewers
@BenjaminHalko
👾 Hi, this is my first Pull Requests over here. Any feedback, changes, or suggestions are welcome! ✌🏼 🏖️