fix(youtube/settings): fix non functional back button in settings

[LisoUseInAIKyrios]

Fixed the back button not working.

integration changes

[oSumAtrIX]

Has this been confirmed to work on non-root as well as root?

[inotia00]

If I remember correctly, for some reason we couldn't declare a new activity in the AndroidManifest in the root environment

For the same reason, TeamVanced also uses LicenseActivity in root builds

[LisoUseInAIKyrios]

In that case it should use the existing strategy of modifying a built in activity. I've reverted to that for this PR.

[0xrxL]

In that case it should use the existing strategy of modifying a built in activity. I've reverted to that for this PR.

Then, in the current state, this fix it's functional for both root/non-root?

[LisoUseInAIKyrios]

Should work for both, yes. It's what's already being used now.

[oSumAtrIX]

@LisoUseInAIKyrios Have you tried if this works on non root before reverting the code?

[LisoUseInAIKyrios]

I don't have a rooted device to try with. Will need confirmation from someone else.

[oSumAtrIX]

You can root an AVD by using this.

[LisoUseInAIKyrios]

I rooted the simulator but so far I cannot do a root installation.

Updating youtube included with the emulator gives:
INSTALL_FAILED_UPDATE_INCOMPATIBLE: Existing package com.google.android.youtube signatures do not match newer version; ignoring!]

This is despite the emulator using an older YouTube version 17.

I uninstalling youtube via adb, and when trying to install youtube.apk somehow the incompatible error still persists even though YouTube appears to be gone.

Also tried manually updating youtube.apk inside the emulator, and it also fails.

[oSumAtrIX]

That is odd, have you tried updating via Google Play store on the emulator?

[LisoUseInAIKyrios]

PlayStore is not available in the emulator. I'm reading that it can be manually enabled by editing config.ini, but it appears that no longer works as with the config change there is still no PlayStore.

I tried again using Android 10 emulator and it refuses to allow uninstalling the built in youtube:

% adb uninstall com.google.android.youtube
Failure [DELETE_FAILED_INTERNAL_ERROR]

It appears a root install on the emulator may not be possible.

[oSumAtrIX]

PlayStore is not available in the emulator

You need an image with GMS. You can select one in AVD Manager.

It appears a root install on the emulator may not be possible.

I have previously successfully updated YouTube on an emulator and mounted a patched app with root.

I suggest trying the AVD image with GMS, as using an emulator can significantly increase productivity.

[LisoUseInAIKyrios]

Ok I see the PlayStore is available for specific emulated devices. Trying that now.

Yes I've found it's a lot faster installing to an emulator (a few seconds vs almost 1 minute for my phone), but I absolutely hate using a trackpad to click and swipe on a small emulator screen vs using a phone with my physical hands.

[oSumAtrIX]

@LisoUseInAIKyrios Yeah, it may not be as easy to use the emulator, though it is preferable not to use your daily driver for development and instead rely on an emulator to avoid problems.

[johnconner122]

Try WSA (Windows Subsystem for Android), it's performance is pretty good.

[LisoUseInAIKyrios]

I changed emulator device to 'Pixel 4' and everything just worked no problem.

But the declared activity is not recognized by the root install:

FATAL EXCEPTION: main
AndroidRuntime: Process: com.google.android.youtube, PID: 1844
AndroidRuntime: android.content.ActivityNotFoundException: Unable to find explicit activity class {com.google.android.youtube/app.revanced.integrations.settingsmenu.ReVancedSettingActivity}; have you declared this activity in your AndroidManifest.xml, or does your intent not match its declared <intent-filter>?

ReVancedSettingActivity is declared in the manifest, and the settings work just fine when using non-root install.

So the current strategy of using an existing activity is still needed.

[inotia00]

yeah.. that's what i was referring to

In the root environment, Vanced and ReVanced are installed with mount -o bind

but when we install with this method, stock YouTube's signature and manifest are used

[0xrxL]

yeah.. that's what i was referring to

In the root environment, Vanced and ReVanced are installed with mount -o bind

but when we install with this method, stock YouTube's signature and manifest are used

Link the solution from your repo at this point.

[inotia00]

Link the solution from your repo at this point.

we don't have to do that
current PR works great enough to be merged immediately

[LisoUseInAIKyrios]

Added an intent filter to the manifest, as it appears to fix shutdown problems on some devices