fix(YouTube - ReturnYouTubeDislike): Fix dislikes not showing on Shor…

…ts (#3133)
ReVanced · Oct 12, 2023 · 0e8a286 · 0e8a286
1 parent 9353305
commit 0e8a286
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/...lin/app/revanced/patches/youtube/layout/returnyoutubedislike/ReturnYouTubeDislikePatch.kt b/...lin/app/revanced/patches/youtube/layout/returnyoutubedislike/ReturnYouTubeDislikePatch.kt
@@ -184,6 +184,9 @@ object ReturnYouTubeDislikePatch : BytecodePatch(
         // Filter that parses the video id from the UI
         LithoFilterPatch.addFilter(FILTER_CLASS_DESCRIPTOR)
 
+        // Player response video id is needed to search for the video ids in Shorts litho components.
+        VideoIdPatch.hookPlayerResponseVideoId("$FILTER_CLASS_DESCRIPTOR->newPlayerResponseVideoId(Ljava/lang/String;)V")
+
         // endregion
 
         // region Hook old UI layout dislikes, for the older app spoofs used with spoof-app-version.

diff --git a/src/main/kotlin/app/revanced/patches/youtube/layout/spoofappversion/SpoofAppVersionPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/layout/spoofappversion/SpoofAppVersionPatch.kt
@@ -62,19 +62,21 @@ object SpoofAppVersionPatch : BytecodePatch(
                 ArrayResource(
                     "revanced_spoof_app_version_target_entries",
                     listOf(
-                        StringResource("revanced_spoof_app_version_target_entry_1", "18.20.39 - Restore wide video speed & quality menu"),
-                        StringResource("revanced_spoof_app_version_target_entry_2", "17.08.35 - Restore old UI layout"),
-                        StringResource("revanced_spoof_app_version_target_entry_3", "16.08.35 - Restore explore tab"),
-                        StringResource("revanced_spoof_app_version_target_entry_4", "16.01.35 - Restore old Shorts player"),
+                        StringResource("revanced_spoof_app_version_target_entry_1", "18.33.40 - Restore RYD Shorts incognito mode"),
+                        StringResource("revanced_spoof_app_version_target_entry_2", "18.20.39 - Restore wide video speed & quality menu"),
+                        StringResource("revanced_spoof_app_version_target_entry_3", "17.08.35 - Restore old UI layout"),
+                        StringResource("revanced_spoof_app_version_target_entry_4", "16.08.35 - Restore explore tab"),
+                        StringResource("revanced_spoof_app_version_target_entry_5", "16.01.35 - Restore old Shorts player"),
                     )
                 ),
                 ArrayResource(
                     "revanced_spoof_app_version_target_entry_values",
                     listOf(
-                        StringResource("revanced_spoof_app_version_target_entry_value_1", "18.20.39"),
-                        StringResource("revanced_spoof_app_version_target_entry_value_2", "17.08.35"),
-                        StringResource("revanced_spoof_app_version_target_entry_value_3", "16.08.35"),
-                        StringResource("revanced_spoof_app_version_target_entry_value_4", "16.01.35"),
+                        StringResource("revanced_spoof_app_version_target_entry_value_1", "18.33.40"),
+                        StringResource("revanced_spoof_app_version_target_entry_value_2", "18.20.39"),
+                        StringResource("revanced_spoof_app_version_target_entry_value_3", "17.08.35"),
+                        StringResource("revanced_spoof_app_version_target_entry_value_4", "16.08.35"),
+                        StringResource("revanced_spoof_app_version_target_entry_value_5", "16.01.35"),
                     )
                 )
             )

diff --git a/src/main/resources/returnyoutubedislike/host/values/strings.xml b/src/main/resources/returnyoutubedislike/host/values/strings.xml
@@ -14,8 +14,9 @@
     <string name="revanced_ryd_enable_summary_off">Dislikes are not shown</string>
 
     <string name="revanced_ryd_shorts_title">Show dislikes on Shorts</string>
-    <string name="revanced_ryd_shorts_summary_on">Dislikes shown on Shorts</string>
+    <string name="revanced_ryd_shorts_summary_on">Dislikes shown on Shorts %s</string>
     <string name="revanced_ryd_shorts_summary_off">Dislikes hidden on Shorts</string>
+    <string name="revanced_ryd_shorts_summary_disclaimer">Limitation: Dislikes will not be shown while in incognito mode</string>
 
     <string name="revanced_ryd_dislike_percentage_title">Dislikes as percentage</string>
     <string name="revanced_ryd_dislike_percentage_summary_on">Dislikes shown as percentage</string>